[cctbxbb] compiler warning in dxtbx

Graeme.Winter at diamond.ac.uk Graeme.Winter at diamond.ac.uk
Mon Nov 4 09:26:07 PST 2013


Did you fix it?

If not please do :-)


Sent from Samsung Mobile



Richard Gildea <rgildea at gmail.com> wrote:


Doesn't line 279 also have the same problem?


    /** @returns True/False This and the other frame are different */
    bool operator!=(const PanelFrame &other) const {
      return *this != other;
    }

Cheers,

Richard

On 4 Nov 2013, at 16:35, Oleg Dolomanov <oleg at olexsys.org<mailto:oleg at olexsys.org>> wrote:

It appears to be corrected,

Cheers, Oleg.

________________________________
From: Graeme.Winter at diamond.ac.uk<mailto:Graeme.Winter at diamond.ac.uk>
To: cctbxbb at phenix-online.org<mailto:cctbxbb at phenix-online.org>
Date: Mon, 4 Nov 2013 16:28:47 +0000
Subject: Re: [cctbxbb] compiler warning in dxtbx

[gw56 at ws133 model]$ svn diff
Index: panel.h
===================================================================
--- panel.h     (revision 18525)
+++ panel.h     (working copy)
@@ -375,7 +375,7 @@



     /** @returns True/False this is not the same as the other */
     bool operator!=(const PanelBase &other) const {
-      return *this != other;
+      return !(*this == other);
     }



   protected:



built fine for me on RHEL6, assume that this is a sound definition as not recursive…



[gw56 at ws133 model]$ svn commit -m "Fix of panel to prevent recursive definition"
Sending        model/panel.h
Transmitting file data .
Committed revision 18527.



Cheerio, Graeme





From: cctbxbb-bounces at phenix-online.org<mailto:cctbxbb-bounces at phenix-online.org> [mailto:cctbxbb-bounces at phenix-online.org<mailto:bounces at phenix-online.org>] On Behalf Of Oleg Dolomanov
Sent: 04 November 2013 16:21
To: cctbxbb at phenix-online.org<mailto:cctbxbb at phenix-online.org>
Subject: [cctbxbb] compiler warning in dxtbx



Hi guys,



there was big change in dxtbx/model/panel.h on the 30th of October (r18499) and apparently the != operator became recursive by calling itself rather than the == operator (line 378) - whoever is responsible - please check/fix,



Cheers,



Oleg.




--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom



_______________________________________________ cctbxbb mailing list cctbxbb at phenix-online.org<mailto:cctbxbb at phenix-online.org> http://phenix-online.org/mailman/listinfo/cctbxbb
_______________________________________________
cctbxbb mailing list
cctbxbb at phenix-online.org<mailto:cctbxbb at phenix-online.org>
http://phenix-online.org/mailman/listinfo/cctbxbb


-- 
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
 





More information about the cctbxbb mailing list