[cctbxbb] pull request - fable

Nic Gould nic.gould.engineer at gmail.com
Tue Apr 25 19:39:26 PDT 2023


Hi All,

Sorry for the intrusion, the Github page suggests contacting the devs on
the mailing list before making a pull request.

I ran into some minor issues building fable and was wondering if it's worth
submitting a pull request.

   - invalid pre-processor directive (fixed upstream at boost
   https://github.com/boostorg/thread/issues/364)
   - Invalid python API call ( fixed upstream at boost here
   https://github.com/boostorg/python/pull/344)
   - Need to install python.h : This one seems tricky as it varies between
   platforms and it's probably not a 'you problem'. Maybe add a line to the
   setup documentation. Interestingly it needs to be installed on the host
   machine, not in the conda venv.

Kind regards

Nic Gould
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://phenix-online.org/pipermail/cctbxbb/attachments/20230426/44eaa7f7/attachment.htm>


More information about the cctbxbb mailing list