<div dir="ltr">One other rule please,<div><br></div><div>6) Before committing code run libtbx.find_clutter and follow the output instructions for adjusting whitespaces and imports to cctbx standards.</div><div><br></div><div>
Nick</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 12, 2013 at 8:06 AM, Nathaniel Echols <span dir="ltr"><<a href="mailto:nechols@lbl.gov" target="_blank">nechols@lbl.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Apr 11, 2013 at 10:20 PM, James Stroud <<a href="mailto:xtald00d@gmail.com">xtald00d@gmail.com</a>> wrote:<br>
> I'm not sure I'd emulate numpy arrays in cctbx myself, as cool as they may<br>
> be. It's usually better to try to find behavior that fits the rest of the<br>
> library in "look and feel". However, if I had SVN commit privileges, I'd<br>
> probably use them occasionally to fix problems I find or make enhancements<br>
> that would aid my work.<br>
<br>
If you want commit access, all I need is a SourceForge user ID.<br>
Basically the only rules are:<br>
<br>
1) Make sure your code actually compiles (to .pyc or .o) on a<br>
supported platform (e.g. a recent Mac) before checking in. �(Sounds<br>
obvious, but people do forget sometimes.)<br>
<br>
2) When changing existing functionality - even just bug fixes - always<br>
run the regression tests.<br>
<br>
[ Ignoring (1) or (2) can and will result in changes being reverted if<br>
we can't figure out how to fix it immediately. ]<br>
<br>
3) If you add functionality, also add a regression test if you don't<br>
want someone else to break it later.<br>
<br>
4) Tread lightly when introducing third-party dependencies (we do this<br>
all the time, of course, but we try to do so in a way that avoids<br>
breaking the library for people who don't have the same dependency<br>
installed).<br>
<br>
5) When in doubt, post your diffs to the cctbxbb for feedback.<br>
<br>
There are other subtleties and complications that inevitably arise,<br>
but I'm a big fan of learning as you go, and I find long lists of<br>
rules inhibit my creativity.<br>
<br>
-Nat<br>
_______________________________________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/mailman/listinfo/cctbxbb</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Nicholas K. Sauter, Ph. D.<br>Computer Staff Scientist,�Physical Biosciences Division<div>Lawrence Berkeley National Laboratory<br>1 Cyclotron Rd., Bldg. 64R0121<br>
Berkeley, CA 94720-8118<br>(510) 486-5713<br></div>
</div>