<div dir="ltr">Thanks for the clarifications.</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr">Cheers<div><br></div><div>Nigel<div><br></div><div>---</div><div>Nigel W. Moriarty<br>Building 33R0349, Molecular Biophysics and Integrated Bioimaging</div><div>Lawrence Berkeley National Laboratory<br>Berkeley, CA 94720-8235<br>Phone : 510-486-5709 Email : NWMoriarty@LBL.gov<br>Fax : 510-486-5909 Web : <a href="http://CCI.LBL.gov" target="_blank">CCI.LBL.gov</a></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Thu, Dec 8, 2016 at 10:12 AM, <span dir="ltr"><<a href="mailto:markus.gerstel@diamond.ac.uk" target="_blank">markus.gerstel@diamond.ac.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Nigel,<br>
<br>
The log (and the blame log) should show the times of the commit, regardless of whether you merge the branch into master or rebase your branch onto master at the end.<br>
<br>
When you rebase your commits you can also get the rebase time. eg. for your last rebased commit:<br>
$ git show 4fa192b0 --format=fuller<br>
The author+date pair is the person who originally wrote the code (rather: who made the original commit), the commit+date pair is set by whoever rebased/cherry-picked/etc. it last.<br>
<br>
-Markus<br>
<br>
<br>
PS: Just to clarify - if you deliberately use branches to do isolated feature development, merging is absolutely fine.<br>
<br>
______________________________<wbr>__<br>
From: <a href="mailto:cctbxbb-bounces@phenix-online.org">cctbxbb-bounces@phenix-online.<wbr>org</a> [<a href="mailto:cctbxbb-bounces@phenix-online.org">cctbxbb-bounces@phenix-<wbr>online.org</a>] on behalf of Nigel Moriarty [<a href="mailto:nwmoriarty@lbl.gov">nwmoriarty@lbl.gov</a>]<br>
Sent: Thursday, December 08, 2016 17:41<br>
To: cctbx mailing list<br>
<span class="">Subject: Re: [cctbxbb] Making branches by accident<br>
<br>
</span><span class="">Markus<br>
<br>
I was a non-rebaser but I have set it to true on my second machine. So my question is regardind branches. I have made a branch, made some changes and merged the master into the branch. I will make some more changes during testing. I assume that I merge into the master at some point. Will the commits appear in the log based on the time of the merge or the time I committed in the branch?<br>
<br>
Cheers<br>
<br>
Nigel<br>
<br>
---<br>
Nigel W. Moriarty<br>
Building 33R0349, Molecular Biophysics and Integrated Bioimaging<br>
Lawrence Berkeley National Laboratory<br>
Berkeley, CA 94720-8235<br>
Phone : <a href="tel:510-486-5709" value="+15104865709">510-486-5709</a> Email : NWMoriarty@LBL.gov<br>
</span>Fax : <a href="tel:510-486-5909" value="+15104865909">510-486-5909</a> Web : <a href="http://CCI.LBL.gov" rel="noreferrer" target="_blank">CCI.LBL.gov</a><<a href="http://CCI.LBL.gov" rel="noreferrer" target="_blank">http://CCI.LBL.gov</a><wbr>><br>
<span class=""><br>
On Thu, Dec 8, 2016 at 12:14 AM, <<a href="mailto:markus.gerstel@diamond.ac.uk">markus.gerstel@diamond.ac.uk</a><<wbr>mailto:<a href="mailto:markus.gerstel@diamond.ac.uk">markus.gerstel@diamond.<wbr>ac.uk</a>>> wrote:<br>
I use a custom prompt so I can see what is going on when I am in a git repository folder.<br>
<br>
This is the code one could add to their ~/.bashrc:<br>
<a href="https://gist.github.com/Anthchirp/dfc9a4382f8dfc9a97fe1039c9e6789a" rel="noreferrer" target="_blank">https://gist.github.com/<wbr>Anthchirp/<wbr>dfc9a4382f8dfc9a97fe1039c9e678<wbr>9a</a><br>
<br>
This is what it looks like:<br>
<a href="https://postimg.org/image/8c9h72qwd/" rel="noreferrer" target="_blank">https://postimg.org/image/<wbr>8c9h72qwd/</a><br>
<br>
This is what happens in the image:<br>
* yellow brackets indicate you are in git territory, and contain the current branch name<br>
* red branch name = uncommitted changes in repository<br>
* positive number: number of commits the local repository is ahead of the remote repository<br>
* the 'git pull' command causes an implicit merge commit, which I undo with the next command<br>
* negative number: number of commits the local repository is behind the remote repository<br>
* both negative and positive number: branches have diverged<br>
<br>
Maybe someone finds it useful.<br>
<br>
-Markus<br>
<br>
<br>
______________________________<wbr>__<br>
</span>From: <a href="mailto:cctbxbb-bounces@phenix-online.org">cctbxbb-bounces@phenix-online.<wbr>org</a><mailto:<a href="mailto:cctbxbb-bounces@phenix-online.org">cctbxbb-bounces@<wbr>phenix-online.org</a>> [<a href="mailto:cctbxbb-bounces@phenix-online.org">cctbxbb-bounces@phenix-<wbr>online.org</a><mailto:<a href="mailto:cctbxbb-bounces@phenix-online.org">cctbxbb-<wbr>bounces@phenix-online.org</a>>] on behalf of Pavel Afonine [<a href="mailto:pafonine@lbl.gov">pafonine@lbl.gov</a><mailto:<a href="mailto:pafonine@lbl.gov">pafon<wbr>ine@lbl.gov</a>>]<br>
<span class="">Sent: Wednesday, December 07, 2016 18:24<br>
</span>To: <a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><<wbr>mailto:<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.<wbr>org</a>><br>
<span class="">Subject: Re: [cctbxbb] Making branches by accident<br>
<br>
This happened to me a few times now, and just double-checked that my .gitconfig contains "rebase = true". Let's see if it happens again..<br>
Pavel<br>
<br>
</span><span class="">On 12/7/16 00:02, <a href="mailto:Graeme.Winter@diamond.ac.uk">Graeme.Winter@diamond.ac.uk</a><<wbr>mailto:<a href="mailto:Graeme.Winter@diamond.ac.uk">Graeme.Winter@diamond.<wbr>ac.uk</a>><mailto:<a href="mailto:Graeme.Winter@diamond.ac.uk">Graeme.Winter@<wbr>diamond.ac.uk</a><mailto:<a href="mailto:Graeme.Winter@diamond.ac.uk">Graeme.<wbr>Winter@diamond.ac.uk</a>>> wrote:<br>
Morning all<br>
<br>
I am seeing a certain amount of “Merge branch 'master' of github.com:cctbx/cctbx_<wbr>project” coming through on the commits – this usually means you did not do a git pull –rebase before the git push. This can be set to the default by using the spell Markus sent out<br>
<br>
git config --global pull.rebase true<br>
<br>
This will need to be done on each machine you push from, else getting the habit of doing a git pull –rebase before push is a good one.<br>
<br>
We have had this on and off with DIALS but it tends to pass easily enough.<br>
<br>
What bad happens? Nothing really but the history becomes confusing…<br>
<br>
So: may be worth checking that you have the pull.rebase thing set?<br>
<br>
Cheerio Graeme<br>
<br>
<br>
<br>
--<br>
<br>
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.<br>
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.<br>
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.<br>
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom<br>
<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cctbxbb mailing list<br>
</span><a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><<wbr>mailto:<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.<wbr>org</a>><mailto:<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-<wbr>online.org</a><mailto:<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@<wbr>phenix-online.org</a>>><br>
<div class="HOEnZb"><div class="h5"><a href="http://phenix-online.org/mailman/listinfo/cctbxbb" rel="noreferrer" target="_blank">http://phenix-online.org/<wbr>mailman/listinfo/cctbxbb</a><br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><<wbr>mailto:<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.<wbr>org</a>><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" rel="noreferrer" target="_blank">http://phenix-online.org/<wbr>mailman/listinfo/cctbxbb</a><br>
<br>
<br>
______________________________<wbr>_________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" rel="noreferrer" target="_blank">http://phenix-online.org/<wbr>mailman/listinfo/cctbxbb</a><br>
</div></div></blockquote></div><br></div>