<div dir="ltr">I profusely apologize for the drama that I've caused. I have now fixed the offending file and vow to be more careful in the future.<div><br></div><div>Art</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 4, 2018 at 4:47 PM, Nigel Moriarty <span dir="ltr"><<a href="mailto:nwmoriarty@lbl.gov" target="_blank">nwmoriarty@lbl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Aaron is correct. It's the first person who is responsible so you can blame Art for the clutter and then completely ignoring the email telling him to fix it.</div><div class="gmail_extra"><span class=""><br clear="all"><div><div class="m_-4159039483016227035gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr">Cheers<div><br></div><div>Nigel<div><br></div><div>---</div><div>Nigel W. Moriarty<br>Building 33R0349, Molecular Biophysics and Integrated Bioimaging</div><div>Lawrence Berkeley National Laboratory<br>Berkeley, CA 94720-8235<br>Phone : 510-486-5709 Email : NWMoriarty@LBL.gov<br>Fax : 510-486-5909 Web : <a href="http://CCI.LBL.gov" target="_blank">CCI.LBL.gov</a></div></div></div></div></div></div></div></div>
<br></span><div class="gmail_quote">On Mon, Jun 4, 2018 at 4:43 PM, Aaron Brewster <span dir="ltr"><<a href="mailto:asbrewster@lbl.gov" target="_blank">asbrewster@lbl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Graeme, I don't find these more annoying than the Jenkins build failure emails. In fact, these buildbot emails are targeted to whoever committed the clutter, or at least the first one is anyway. Be happy, Nigel and I get *all* the buildbot continuous-integration emails, you only get a couple!<div><br></div><div>A smarter build-bot post-commit hook would be nice, one that only alerts once per bad commit. The relevant class is BBCCTBXCIBuilder in master.cfg in the cci buildbot svn repo. It would need to get the last commit and only run find_clutter on those files. Perhaps a --last-commit-only flag could be added to libtbx.find_clutter, which could then be used by <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">BBCCTBXCIBuilder? Of course, then untended clutter could start to build up...</span><span class="m_-4159039483016227035HOEnZb"><font color="#888888"><div><div><br></div><div>-Aaron<br><div><div><br></div><div><br></div></div></div></div></font></span></div></div><div class="m_-4159039483016227035HOEnZb"><div class="m_-4159039483016227035h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 4, 2018 at 4:25 AM, <a href="mailto:Graeme.Winter@Diamond.ac.uk" target="_blank">Graeme.Winter@Diamond.ac.uk</a> <span dir="ltr"><<a href="mailto:Graeme.Winter@diamond.ac.uk" target="_blank">Graeme.Winter@diamond.ac.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Folks,<br>
<br>
Am I alone in finding this kind of message ** very ** annoying<br>
<br>
I did not touch this file<br>
I have no business touching this file<br>
If I do fix this then it may cause conflicts for others, which will no doubt annoy them far more than the odd extra space in the code<br>
<br>
However I am also now to blame for breaking the Phenix build, in the run up to a release<br>
<br>
This is no a happy place<br>
<br>
Suggestions?<br>
<br>
Thanks & cheerio Graeme<br>
<br>
Begin forwarded message:<br>
<br>
From: <a href="mailto:phenix@phenix-online.org" target="_blank">phenix@phenix-online.org</a><mailt<wbr>o:<a href="mailto:phenix@phenix-online.org" target="_blank">phenix@phenix-online.org</a>><span class=""><br>
Subject: buildbot failure in Phenix on cctbx-ci-ci<br></span>
Date: 4 June 2018 at 12:11:19 BST<br>
To: <a href="mailto:graeme.winter@gmail.com" target="_blank">graeme.winter@gmail.com</a><mailto<wbr>:<a href="mailto:graeme.winter@gmail.com" target="_blank">graeme.winter@gmail.com</a>><br>
Cc: ASBrewster@LBL.Gov<mailto:<a href="mailto:ASBrewster@LBL.Gov" target="_blank">ASBr<wbr>ewster@LBL.Gov</a>>, NWMoriarty@LBL.Gov<mailto:<a href="mailto:NWMoriarty@LBL.Gov" target="_blank">NWMo<wbr>riarty@LBL.Gov</a>><br>
<span><span class=""><br>
Build status: FAILURE<br>
Buildslave for this Build: ci<br></span>
Complete logs for all build steps: <a href="http://cci-vm-6.lbl.gov:8010/builders/cctbx-ci-ci/builds/5580" rel="noreferrer" target="_blank">http://cci-vm-6.lbl.gov:8010/b<wbr>uilders/cctbx-ci-ci/builds/558<wbr>0</a><span class=""><br>
Build Reason: The SingleBranchScheduler scheduler named 'cctbx-ci.poll' triggered this build<br>
Build Source Stamp: clipper: [branch master] HEAD<br>
<br>
cbflib: [branch master] HEAD<br>
<br></span>
cctbx_project: [branch master] 4de5e7f82b0302632282f78c6dda8b<wbr>999cf6abf6<span class=""><br>
<br>
annlib_adaptbx: [branch master] HEAD<br>
<br>
tntbx: [branch master] HEAD<br>
<br>
ccp4io_adaptbx: [branch master] HEAD<br>
<br>
boost: [branch master] HEAD<br>
<br>
gui_resources: [branch master] HEAD<br>
<br>
<br></span>
Blamelist: graeme-winter<span class=""><br>
If you got an email and you didn't touch this file, it may because someone commited this file before you with an error and hasn't fixed it yet. You might have noticed the error if you ran libtbx.find_clutter on the entire tree.<br>
<br>
</span></span>Detailed log of last build step: <a href="http://cci-vm-6.lbl.gov:8010/builders/cctbx-ci-ci/builds/5580/steps/test" rel="noreferrer" target="_blank">http://cci-vm-6.lbl.gov:8010/b<wbr>uilders/cctbx-ci-ci/builds/558<wbr>0/steps/test</a> ALL clutter/logs/stdio<<a href="http://cci-vm-6.lbl.gov:8010/builders/cctbx-ci-ci/builds/5580/steps/test%20ALL%20clutter/logs/stdio" rel="noreferrer" target="_blank">http://cci-<wbr>vm-6.lbl.gov:8010/builders/cct<wbr>bx-ci-ci/builds/5580/steps/tes<wbr>t%20ALL%20clutter/logs/stdio</a>><span class=""><br>
<div class="m_-4159039483016227035m_3218991556275026381HOEnZb"><div class="m_-4159039483016227035m_3218991556275026381h5">Last 80 lines of "test ALL clutter.stdio"<br>
<br>
iota/command_line/iota_single_<wbr>image.py: tabs or trailing whitespace=2, #10, #11<br>
<br>
*** To clean up please use: libtbx.clean_clutter ***<br>
<br>
<br>
-The Buildbot<br>
<br>
<br>
</div></div></span><span class="m_-4159039483016227035m_3218991556275026381HOEnZb"><font color="#888888">-- <br>
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.<br>
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. <br>
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.<br>
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom<br>
<br>
<br>
______________________________<wbr>_________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" rel="noreferrer" target="_blank">http://phenix-online.org/mailm<wbr>an/listinfo/cctbxbb</a><br>
</font></span></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" rel="noreferrer" target="_blank">http://phenix-online.org/mailm<wbr>an/listinfo/cctbxbb</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Artem Y. Lyubimov, PhD<br>Staff Scientist<br>SSRL SMB Crystallography<br>2525 Sand Hill Road mail stop 99<br>Menlo Park, CA 94025-7015<br>(650) 926-5595</div></div>
</div>