I made some progress towards reducing the number of compiler warnings in https://github.com/cctbx/cctbx_project/pull/523, but clearly there are still many warnings remaining, depending on platform, compiler etc. I would definitely support efforts in reducing the number of compiler warnings.
Dr Richard Gildea
Data Analysis Scientist
Tel: +441235 77 8078
Diamond Light Source Ltd.
Diamond House
Harwell Science & Innovation Campus
Didcot
Oxfordshire
OX11 0DE
________________________________
From: [email protected] on behalf of Winter, Graeme (DLSLtd,RAL,LSCI)
Sent: 24 September 2020 16:55
To: cctbx mailing list
Subject: [cctbxbb] Warnings (by the hundredweight)
Hi Folks
Spent this afternoon looking at
https://github.com/cctbx/cctbx_project/issues/532
which involves touching C++ header code deep in scitbx - which is fine - but every recompile generates hundreds of warnings from all over the place so your actual compiler errors are completely obscured
Massive amounts of deprecation errors everywhere e.g.
In file included from /Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/maptbx/asymmetric_map.cpp:5:
In file included from /Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/maptbx/asymmetric_map.h:18:
In file included from /Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/sgtbx/direct_space_asu/proto/asymmetric_unit.h:6:
In file included from /Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/sgtbx/direct_space_asu/proto/direct_space_asu.h:9:
/Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/sgtbx/direct_space_asu/proto/facet_collection.h:72:34: warning: 'pointer' is deprecated [-Wdeprecated-declarations]
faces_ = facet_collection::pointer(a.faces_->new_copy());
In file included from /Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/sgtbx/direct_space_asu/proto/asymmetric_unit.h:6:
In file included from /Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/sgtbx/direct_space_asu/proto/direct_space_asu.h:9:
/Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/sgtbx/direct_space_asu/proto/facet_collection.h:78:33: warning: 'pointer' is deprecated [-Wdeprecated-declarations]
faces(const facet_collection::pointer &a) : faces_(a->new_copy()) {}
^
/Users/graeme/svn/cctbx/conda_base/bin/../include/c++/v1/memory:2130:28: note: 'auto_ptrcctbx::sgtbx::asu::facet_collection' has been explicitly marked deprecated here
class _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX11 auto_ptr
^
/Users/graeme/svn/cctbx/conda_base/bin/../include/c++/v1/__config:972:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX11'
# define _LIBCPP_DEPRECATED_IN_CXX11 _LIBCPP_DEPRECATED
^
/Users/graeme/svn/cctbx/conda_base/bin/../include/c++/v1/__config:961:48: note: expanded from macro '_LIBCPP_DEPRECATED'
# define _LIBCPP_DEPRECATED __attribute__ ((deprecated))
is there any appetite on the list to reduce the number of compiler warnings to make development easier?
Thanks Graeme
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
