On 7 Oct 2020, at 14:23, Robert Oeffner <[email protected]> wrote:
Sorry about the noise in the commit history. I have now put a pre-commit hook in my git settings that runs clean_clutter on my clone of the cctbx repo.
Rob
On 07-10-2020 13:36, Winter, Graeme (DLSLtd,RAL,LSCI) wrote:
Hi Folks
Would anyone be offended if we had a pre-commit hook which ran the clutter / unused imports tests to stop the history fulling up with clean clutter commits?
If clutter is important, probably should not let it in in the first place?
I’m not suggesting anything extreme like black, like we use for dxtbx and dials, just running the tools that developers are supposed to run before commits
Cheers Graeme
Begin forwarded message:
From: CCTBX commit <[email protected]>
Subject: [git/cctbx_project] master: de-clutter (e9be98075a)
Date: 7 October 2020 at 12:56:50 BST
Reply-To: [email protected]
Repository : https://github.com/cctbx/cctbx_project/
On branch : master
Link : https://github.com/cctbx/cctbx_project/commit/e9be98075a31f4584f1eca41f9eba5e408d0cb8f
commit e9be98075a31f4584f1eca41f9eba5e408d0cb8f
Author: Robert Oeffner <[email protected]>
Date: Wed Oct 7 12:56:50 2020 +0100
de-clutter
e9be98075a31f4584f1eca41f9eba5e408d0cb8f
cctbx/miller/__init__.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
To unsubscribe from the CCTBX-COMMIT list, click the following link:
https://www.jiscmail.ac.uk/cgi-bin/WA-JISC.exe?SUBED1=CCTBX-COMMIT&A=1
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
_______________________________________________ cctbxbb mailing list [email protected] http://phenix-online.org/mailman/listinfo/cctbxbb-- Robert Oeffner, Ph.D. Research Associate, The Read Group Department of Haematology, Cambridge Institute for Medical Research University of Cambridge Cambridge Biomedical Campus The Keith Peters Building Hills Road Cambridge CB2 0XY www.cimr.cam.ac.uk/investigators/read/index.html tel: +44(0)1223 763234
Virus-free. www.avg.com
--
This e-mail and any attachments may contain
confidential, copyright and or privileged material, and are for
the use of the intended addressee only. If you are not the
intended addressee or an authorised recipient of the addressee
please notify us of receipt by returning the e-mail and do not
use, copy, retain, distribute or disclose the information in or
attached to the e-mail.
Any opinions expressed within this e-mail are those of the
individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or
any attachments are free from viruses and we cannot accept
liability for any damage which you may sustain as a result of
software viruses which may be transmitted in or with the
message.
Diamond Light Source Limited (company no. 4375679). Registered
in England and Wales with its registered office at Diamond
House, Harwell Science and Innovation Campus, Didcot,
Oxfordshire, OX11 0DE, United Kingdom