[cctbxbb] proposal to remove iotbx.shelx.from_ins

[Luc Bourhis]

Hi Mirko,

> since I am new here it seems an odd proposal, but could you not remove
> iotbx.shelx.from_ins.from_ins since its functionality is covered much
> better by xray.structure.from_shelx (at least it seems to me).  

You are correct that the latter supersedes the former. 

> from_ins is used only here
> 
> ./iotbx/command_line/emma.py
> ./cctbx/adp_restraints/tst_ext.py

Agreed. When I committed xray.structure.from_shelx I was probably afraid to break Phenix if I had removed from_ins.from_ins. But those 2 instances you quoted are the only ones I can find anywhere in the Phenix universe.

So Nat, does it make sense to remove iotbx.shelx.from_ins.from_ins entirely?

Luc