[cctbxbb] match_indices.paired_miller_indices() ungraceful overshoot
jhattne at lbl.gov
Mon Apr 8 13:55:41 PDT 2013
I think you're right in that it's redundant, and exercise_match_indices() in boost_python/tst_miller.py succeeds with i_array==0 and i_array==1 alike. However, changing it will break the interface.
On 6 Apr 2013, at 00:51, James Stroud <xtald00d at GMAIL.COM> wrote:
> Actually, is i_array even necessary as an argument? It's not clear to me when the two alternate values for i_array will make a difference in the return value.
> On Apr 6, 2013, at 1:44 AM, James Stroud wrote:
>> Hello all,
>> I accidentally gave paired_miller_indices() a value > 1 for i_array, and got a segfault. The problem looks to be in match_indices.cpp, line 94:
>> Maybe there should be a test that raises an exception on the python side, if possible.
> cctbxbb mailing list
> cctbxbb at phenix-online.org
Postdoctoral Fellow @ Physical Biosciences Division
Lawrence Berkeley National Laboratory * 1 Cyclotron Rd.
Mail Stop 64R0121 * Berkeley, CA 94720-8118 * +1 (510) 495-8055
More information about the cctbxbb