[cctbxbb] First svn commit
Jan Marten Simons
marten at xtal.rwth-aachen.de
Thu Apr 18 05:38:48 PDT 2013
Am Donnerstag 18 April 2013 09:40:27 schrieb James Stroud:
> Thanks everyone for the feedback. I have never really collaborated on code,
> so I am in definite need of community opinion on matters of style.
>
> I have changed the method to reflect the present vote of 3:1 for explicit
> argument lists, and will keep the sentiment in mind in the future. I have
> also renamed the method as_miller_arrays_dict. I figure the rename is safe
> because it has only been a couple of hours since I pushed the original
> code.
If you've got some additional time it would be great, if you could also
document the arguments and the return value(s) of the function in sphinx style
(= :param...: / see xray/structure.py) for quite a few examples.
Cheers,
Jan
More information about the cctbxbb
mailing list