[cctbxbb] shall iotbx really depends on dxtbx?

[Graeme.Winter at diamond.ac.uk]

Luc

commit 18dd82e4334f19616f6784c3c24b322d6292d955
Author: Nicholas Sauter <nksauter at lbl.gov<mailto:nksauter at lbl.gov>>
Date:   Sun Jun 2 19:43:52 2013 +0000

    The current LABELIT build DOES NOT WORK AT ALL without bundling the dxtbx dependency.  However, this is not particular to LABELIT; any application such as DIALS depending on dxtbx will fail.

In iotbx/detectors

Graemes-MacBook-Pro-5:iotbx graeme$ grep -R dxtbx .
./detectors/__init__.py:    from dxtbx.format.Registry import Registry
Binary file ./detectors/__init__.pyc matches
./detectors/adsc.py:    self.open_file = open # default: open files with built-in, unless otherwise instructed by dxtbx format
./detectors/context/config_detector.py:    elif imageobject.vendortype=="Pilatus Single Module": # provisional support for EDF; refactor for upcoming dxtbx migration
./detectors/eiger.py:  def readHeader(self,dxtbx_instance,maxlength=12288): # XXX change maxlength!!!
./detectors/eiger.py:      D = dxtbx_instance.get_detector()
./detectors/eiger.py:      B = dxtbx_instance.get_beam()
./detectors/eiger.py:      self._image_count = dxtbx_instance.get_num_images()
./detectors/eiger.py:      S = dxtbx_instance.get_scan()
./detectors/eiger.py:      dxtbx_instance.vendortype = self.vendortype
Binary file ./detectors/eiger.pyc matches
./libtbx_config:  "modules_required_for_use": ["cctbx", "fable", "ucif", "smtbx", "dxtbx"],

So it does, but only for iotbx.detectors - which makes sense…

Cheers Graeme

On 26 May 2017, at 14:38, Luc Bourhis <luc_j_bourhis at mac.com<mailto:luc_j_bourhis at mac.com>> wrote:

Hi,

iotbx/libtbx_config:

{
 "modules_required_for_use": ["cctbx", "fable", "ucif", "smtbx", "dxtbx"],
 "optional_modules": ["ccp4io", "cbflib"],
}

A search for dxtbx in the source code of iotbx does not return anything. Did I miss something? Moreover dxtbx/libtbx_config:

{
 "modules_required_for_use" : [ "iotbx" ],
}

The problem is that dxtbx pulls in HDF5 and that it fails to compiles on Windows 64 with a 64-bit Python, a configuration we need for Olex 2. If the solution was as simple as dropping the dependence of iotbx on dxtbx, that would make my day!

Thoughts?

Best wishes,

Luc Bourhis

_______________________________________________
cctbxbb mailing list
cctbxbb at phenix-online.org<mailto:cctbxbb at phenix-online.org>
http://phenix-online.org/mailman/listinfo/cctbxbb


-- 
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom