[cctbxbb] How does Jenkins work?

Sat Jul 28 00:28:51 PDT 2018

Hi Markus and Nick,

Thank you very much for explanation.
Now it is clear and I feel assured that I didn't break anything :-)

For records, I write what happened below.

> but your commits are now separated from his. So my best guess as to what happened is
> * you originally made your commits on top of Billy's in a branch named dlstbx-sacla
> * you either
>    * pushed the dlstbx-sacla branch to Github before making your 3rd commit, or

Yes. I pushed the first two commits to dxtbx-sacla first.

> * at which point Jenkins was triggered on dlstbx-sacla, seeing only the 2nd commit, and
> * Jenkins fails

Correct. That triggered a test failure and Jenkins sent an email. This
is normal. Then I pushed the third commit, which fixed the test failure.
I confirmed it by a check mark on GitHub commits page.
So I rebased it into master and deleted the dxtbx-sacla branch.
Again tests passed fine.

The problem is that Jenkins sent the error mail _again_ on the already
deleted dxtbx-sacla branch. Probably this was caused by the
configuration bug Nick mentioned.

Best regards,

Takanori Nakane

> As Graeme implied though, there is no "penalty" associated with Jenkins failing on branches other than master.
> Generally nobody (apart from yourself) will expect other branches to be stable, and they are not relevant for releases etc.
> So like Graeme, I ignore any failure mails of branches that I am not personally involved in.
> If a branch is part of a pull request and is supposed to be merged into master then that may be different, as at which point tests should succeed. But then the latest (and relevant) Jenkins output will be prominently visible in the Github pull request itself.
> 
> -Markus
> 
> 
> -----Original Message-----
> From: cctbxbb-bounces at phenix-online.org <cctbxbb-bounces at phenix-online.org> On Behalf Of Takanori Nakane
> Sent: 27 July 2018 17:19
> To: cctbx mailing list <cctbxbb at phenix-online.org>
> Subject: Re: [cctbxbb] How does Jenkins work?
> 
> Hi Graeme,
> 
> Thank you very much for your advise.
> I'll wait and see if Jenkins still complains.
> 
> Best regards,
> 
> Takanori Nakane
> 
>> Dear Takanori
>>
>> Both of our resident Git gurus are en route to Lewiston, ME so
>> unlikely to pick this one up for a day or two
>>
>> I would expect words like upstream synchronisation or similar will
>> appear in the answer, but I would quite frankly hold tight & ignore
>> the Jenkins emails - I was surprised to see it too, as I recall it
>> being fixed, but figured that there was something odd happening.
>>
>> Sorry I can't be more help, best wishes Graeme
>>
>>> On 27 Jul 2018, at 11:52, Takanori Nakane <tnakane at mrc-lmb.cam.ac.uk>
>>> wrote:
>>>
>>> Hi,
>>>
>>> Why does Jenkins still run tests on my old commits on my deleted
>>> (dxtbx-sacla) branch? The test failure is probably caused by my
>>> commit dc17165 but I committed a fix 5c7416b and confirmed that it
>>> passes the tests. So I merged my topic branch to master and deleted
>>> the branch from GitHub.
>>>
>>> I know how git works but I am new to the practice in the cctbx
>>> repository (like using rebase instead of merge). If I am doing
>>> something wrong, could you please point it to me?
>>>
>>> Best regards,
>>>
>>> Takanori Nakane
>>>
>>>> <html><head></head><body><table style="width:100%; background-color:
>>>> #F59400; color: #FFF; border-radius: 0.5em; margin-bottom:
>>> 0.5em"><tr><td
>>>> style="margin: 0.5em 1.25em 0.5em 0.7em; font-weight: bold;
>>>> font-family:
>>>> sans-serif; font-size: 110%"><a
>>>> href="http://jenkins.diamond.ac.uk:8080/job/cctbx_branch_tests/145/"
>>>> style="color:#FFF; text-decoration: none"><big>Build CCTBX Branch
>>>> Tests
>>> is
>>>> unstable</big></a></td></tr></table><br/><table style="width:100%;
>>>> background-color: #F59400; color: #FFF; border-radius: 0.5em;
>>>> margin-bottom: 0.5em"><tr><td style="margin: 0.5em 1.25em 0.5em
>>>> 0.7em;
>>>> font-weight: bold; font-family: sans-serif; font-size: 110%"><a
>>>> href="http://jenkins.diamond.ac.uk:8080/job/cctbx_branch_tests/145/testReport"
>>>> style="color:#FFF; text-decoration: none">3 out of 940 tests failed
>>>> (132
>>>> skipped)</a></td></tr></table><table style="margin: 0.5em 0 1em
>>>> 2em"><tr><td><pre style="font-size:80%">3 tests failed.
>>>> FAILED:
>>>> dxtbx.build_dials.modules.cctbx_project.dxtbx.tests.test_regression_
>>>> images.test_no_multiple_format_understanding[SACLA_MPCCD_Cheetah/run
>>>> 266702-0-subset.h5]
>>>> Error Message:
>>>> exit code 1
>>>> Stack Trace:
>>>> FAILED:
>>>> dxtbx.build_dials.modules.cctbx_project.dxtbx.tests.test_regression_
>>>> images.test_no_multiple_format_understanding[putative_imgCIF_HDF5_ma
>>>> pping/minicbf.h5]
>>>> Error Message:
>>>> exit code 1
>>>> Stack Trace:
>>>> FAILED:
>>>> dxtbx.build_dials.modules.cctbx_project.dxtbx.tests.test_regression_
>>>> images.test_no_multiple_format_understanding[putative_imgCIF_HDF5_ma
>>>> pping/X4_wide_M1S4_1.nxs]
>>>> Error Message:
>>>> exit code 1
>>>> Stack Trace:
>>>> </pre></td></tr></table><table style="width:100%; background-color:
>>>> #F59400; color: #FFF; border-radius: 0.5em; margin-bottom:
>>> 0.5em"><tr><td
>>>> style="margin: 0.5em 1.25em 0.5em 0.7em; font-weight: bold;
>>>> font-family:
>>>> sans-serif; font-size: 110%">Changes since the last successful
>>>> build</td></tr></table><table style="margin: 0.5em 0 1em
>>>> 2em"><tr><td><table style="padding: 0.1em 0.4em; background-color:
>>>> #F59400; color:#fff"><tr><td>145</td></tr></table></td><td>No
>>>> changes </td></tr></table><table style="width:100%;
>>>> background-color: #CCC;
>>> color:
>>>> #000; border-radius: 0.5em; margin-bottom: 0.5em"><tr><td
>>>> style="margin:
>>>> 0.5em 1.25em 0.5em 0.7em; font-weight: bold; font-family:
>>>> sans-serif;
>>>> font-size: 110%">Build environment</td></tr></table><table
>>> style="margin:
>>>> 0.5em 0 1em 2em"><tr><td><span
>>>> style="font-size:130%">&nbsp;[&nbsp;</span>cctbx <strong>71a4ab94a
>>>> 2018-07-25 06:47:08 +0900</strong><span
>>>> style="font-size:130%">&nbsp;&#124;&nbsp;</span>DIALS regression
>>>> <strong>1924</strong>, PHENIX regression <strong>4419</strong>, DLS
>>>> Jenkins scripts <strong>8de8b58 2018-07-04 23:29:22
>>>> +0100</strong><span
>>>> style="font-size:130%">&nbsp;]&nbsp;</span></td></tr></table><span
>>>> style="color:#CCC;font-size:80%">mail template revision
>>>> 2487</span></body></html> <br> <hr> <p align="center">To unsubscribe
>>>> from the CCTBX-COMMIT list, click the following link:<br> <a
>>>> href="https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=CCTBX-COMMIT&A=1"
>>>> target="_blank">https://www.jiscmail.ac.uk/cgi-bin/webadmin?SUBED1=C
>>>> CTBX-COMMIT&A=1</a>
>>>> </p>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> cctbxbb mailing list
>>> cctbxbb at phenix-online.org
>>> http://phenix-online.org/mailman/listinfo/cctbxbb
>>
>>
>> --
>> This e-mail and any attachments may contain confidential, copyright
>> and or privileged material, and are for the use of the intended addressee only.
>> If you are not the intended addressee or an authorised recipient of
>> the addressee please notify us of receipt by returning the e-mail and
>> do not use, copy, retain, distribute or disclose the information in or
>> attached to the e-mail.
>> Any opinions expressed within this e-mail are those of the individual
>> and not necessarily of Diamond Light Source Ltd.
>> Diamond Light Source Ltd. cannot guarantee that this e-mail or any
>> attachments are free from viruses and we cannot accept liability for
>> any damage which you may sustain as a result of software viruses which
>> may be transmitted in or with the message.
>> Diamond Light Source Limited (company no. 4375679). Registered in
>> England and Wales with its registered office at Diamond House, Harwell
>> Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United
>> Kingdom
>>
>> _______________________________________________
>> cctbxbb mailing list
>> cctbxbb at phenix-online.org
>> http://phenix-online.org/mailman/listinfo/cctbxbb
>>
> 
> 
> _______________________________________________
> cctbxbb mailing list
> cctbxbb at phenix-online.org
> http://phenix-online.org/mailman/listinfo/cctbxbb
> 