[cctbxbb] non-standard test naming in mmtbx

[Graeme.Winter@Diamond.ac.uk]

Hi Nigel,

I read Nick’s question differently - some projects do use pytest - so may accidentally pick these tests up and then fail.

The request was to rename the four files as

"Is there any reason they should not be renamed from “test_*.py” to “tst_*.py”?”

for

"$D/conformation_dependent_library/test_cdl.py",
   "$D/conformation_dependent_library/test_cdl_esd.py",
“$D/conformation_dependent_library/test_rdl.py",
"$D/conformation_dependent_library/test_hpdl.py”,

which seems like a reasonable compromise i.e. keep the existing testing scheme and flag that these are “traditional style” libtbx tests  by the prefix tst

Best wishes Graeme

On 3 Oct 2018, at 11:04, Nigel Moriarty <nwmoriarty at lbl.gov<mailto:nwmoriarty at lbl.gov>> wrote:

These tests were added before pytest was ever considered for use with cctbx so there was no reason to follow the convention of which you speak when writing the tests. The testing system that we use works fine so I'm not sure why reimplementing it is necessary. We are happy to help you get up and running with the current system.

Cheers

Nigel

---
Nigel W. Moriarty
Building 33R0349, Molecular Biophysics and Integrated Bioimaging
Lawrence Berkeley National Laboratory
Berkeley, CA 94720-8235
Phone : 510-486-5709     Email : NWMoriarty at LBL.gov<mailto:NWMoriarty at LBL.gov>
Fax   : 510-486-5909       Web  : CCI.LBL.gov<http://cci.lbl.gov/>


On Tue, Oct 2, 2018 at 6:58 PM Pearce, N.M. (Nick) <n.m.pearce at uu.nl<mailto:n.m.pearce at uu.nl>> wrote:
Hi,

I’m trying to use the automatic pytest discovery in mmtbx and I notice that there are a few “libtbx-style” tests, namely
        "$D/conformation_dependent_library/test_cdl.py",
        "$D/conformation_dependent_library/test_cdl_esd.py",
        “$D/conformation_dependent_library/test_rdl.py",
        "$D/conformation_dependent_library/test_hpdl.py”,
that follow the “pytest” naming convention, and are thus picked up by the pytest.discover() function. They then error because pytest cannot run them.

There are — as far as I can tell — normal libtbx tests (they are registered in run_tests.py). Is there any reason they do not follow the typical naming convention?

Changing their filenames and modifying run_tests.py accordingly seems to lead to the same behaviour when running tests.

Is there any reason they should not be renamed from “test_*.py” to “tst_*.py”?

Thanks,
Nick



_______________________________________________
cctbxbb mailing list
cctbxbb at phenix-online.org<mailto:cctbxbb at phenix-online.org>
http://phenix-online.org/mailman/listinfo/cctbxbb
_______________________________________________
cctbxbb mailing list
cctbxbb at phenix-online.org<mailto:cctbxbb at phenix-online.org>
http://phenix-online.org/mailman/listinfo/cctbxbb


-- 
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom