[cctbxbb] cctbx azure pipelines skipping tests if clutter

richard.gildea at diamond.ac.uk richard.gildea at diamond.ac.uk
Wed Aug 14 01:56:06 PDT 2019


I noticed that the cctbx azure pipelines run libtbx.find_clutter as part of the Python "syntax" jobs, and if they find any "clutter", then the pipeline immediately fails and doesn't run any further tests (e.g. https://dev.azure.com/cctbx/cctbx_project/_build/results?buildId=374). This raises the following questions:

1) Why skip running tests just because "clutter" has been found?

2) Why run libtbx.find_clutter as part of the "syntax" job, as strictly speaking trailing whitespaces, unused imports etc, aren't syntax issues?

3) If finding clutter is so important, why not add an optional pre-commit hook to help prevent "clutter" ever being committed in the first place?



Dr Richard Gildea
Data Analysis Scientist
Tel: +441235 77 8078

Diamond Light Source Ltd.
Diamond House
Harwell Science & Innovation Campus
OX11 0DE

This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom

More information about the cctbxbb mailing list