[cctbxbb] Python 2 only code

Winter, Graeme (DLSLtd,RAL,LSCI) Graeme.Winter at diamond.ac.uk
Tue Mar 3 23:46:57 PST 2020

Morning all,

Looking at commits overnight saw


which adds Python 2 only code to cctbx - I thought there were things in place which prevent regressions such as this?

Error: the following jobs returned non-zero exit codes or suspicious stderr output:

libtbx.python "/Users/graeme/svn/cctbx/modules/cctbx_project/iotbx/pdb/tst_hierarchy.py" [FAIL] 1.0s
  Time:  1.04
  Return code: 1
  OKs: 0
  Standard error:
    Traceback (most recent call last):
      File "/Users/graeme/svn/cctbx/modules/cctbx_project/iotbx/pdb/tst_hierarchy.py", line 7082, in <module>
      File "/Users/graeme/svn/cctbx/modules/cctbx_project/iotbx/pdb/tst_hierarchy.py", line 7069, in exercise
      File "/Users/graeme/svn/cctbx/modules/cctbx_project/iotbx/pdb/tst_hierarchy.py", line 5845, in exercise_other
        assert pdb_hierarchy.contains_protein()
      File "/Users/graeme/svn/cctbx/modules/cctbx_project/iotbx/pdb/hierarchy.py", line 1623, in contains_protein
        classes=['common_amino_acid', 'modified_amino_acid'])
      File "/Users/graeme/svn/cctbx/modules/cctbx_project/iotbx/pdb/hierarchy.py", line 214, in get_n_residues_of_classes
        for resname, count in self.resnames.iteritems():
    AttributeError: 'dict' object has no attribute ‘iteritems’

Given how much noise you will receive if you leave trailing whitespace in there, I’d like to think real errors like this would be picked up automatically?

Cheers Graeme

This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://phenix-online.org/pipermail/cctbxbb/attachments/20200304/38579992/attachment.htm>

More information about the cctbxbb mailing list