[cctbxbb] Clutter etc.

Sat Oct 3 05:03:05 PDT 2020

Also…

How / why does clutter on master break builds on a PR?

Thanks Graeme

On 3 Oct 2020, at 12:53, Winter, Graeme (DLSLtd,RAL,LSCI) <Graeme.Winter at diamond.ac.uk<mailto:Graeme.Winter at diamond.ac.uk>> wrote:

OK, this comes from

https://github.com/cctbx/cctbx_project/commit/02bb815eda2ae95c4289877580905c41b3cd14a5

Took liberty of commenting out in

https://github.com/cctbx/cctbx_project/commit/fee091e5ca654cc5d1cccc4afa85b095d89660d1

as I would quite like to have my tests pass on the branch…

On 3 Oct 2020, at 12:32, Winter, Graeme (DLSLtd,RAL,LSCI) <Graeme.Winter at diamond.ac.uk<mailto:Graeme.Winter at diamond.ac.uk>> wrote:

Hi Folks

Please could we make less of a big deal about clutter?

I have been hacking away for weeks at a PR & errors such as

2020-10-03T09:39:50.9328925Z Generating script.
2020-10-03T09:39:50.9348357Z ========================== Starting Command Output ===========================
2020-10-03T09:39:50.9378363Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/2787f38a-d1cc-4c10-b0bd-c9b041b41631.sh
2020-10-03T09:40:32.0565443Z
2020-10-03T09:40:32.0566065Z mmtbx/model/model.py: unused imports=1
2020-10-03T09:40:32.0566273Z
2020-10-03T09:40:32.0566573Z *** To clean up please use: libtbx.find_unused_imports_crude ***
2020-10-03T09:40:32.0566824Z
2020-10-03T09:40:32.0711947Z
2020-10-03T09:40:32.0785277Z ##[error]Bash exited with code '1'.
2020-10-03T09:40:32.0802183Z ##[section]Finishing: Check for clutter
2020-10-03T09:40:32.0831426Z ##[section]Starting: Checkout cctbx/cctbx_project at refs/pull/533/merge to ./modules/cctbx_project
2020-10-03T09:40:32.0841670Z ==============================================================================
2020-10-03T09:40:32.0842063Z Task         : Get sources
2020-10-03T09:40:32.0842444Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-10-03T09:40:32.0842850Z Version      : 1.0.0
2020-10-03T09:40:32.0843106Z Author       : Microsoft
2020-10-03T09:40:32.0843503Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-10-03T09:40:32.0843947Z ==============================================================================
2020-10-03T09:40:32.4896538Z Cleaning any cached credential from repository: cctbx/cctbx_project (GitHub)
2020-10-03T09:40:32.4948059Z ##[section]Finishing: Checkout cctbx/cctbx_project at refs/pull/533/merge to ./modules/cctbx_project
2020-10-03T09:40:32.5010291Z ##[section]Starting: Finalize Job
2020-10-03T09:40:32.5043249Z Cleaning up task key
2020-10-03T09:40:32.5044549Z Start cleaning up orphan processes.
2020-10-03T09:40:32.5217555Z ##[section]Finishing: Finalize Job
2020-10-03T09:40:32.5261526Z ##[section]Finishing: syntax python2.7

are making it hard to actually make the tests pass (this change is something I have not touched)

Is it really worth breaking builds in PR’s because of some white space / unused imports in unrelated files?

Cheers Graeme
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom

_______________________________________________
cctbxbb mailing list
cctbxbb at phenix-online.org<mailto:cctbxbb at phenix-online.org>
http://phenix-online.org/mailman/listinfo/cctbxbb

--

This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom

_______________________________________________
cctbxbb mailing list
cctbxbb at phenix-online.org<mailto:cctbxbb at phenix-online.org>
http://phenix-online.org/mailman/listinfo/cctbxbb

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://phenix-online.org/pipermail/cctbxbb/attachments/20201003/0294c464/attachment.htm>