[cctbxbb] [git/cctbx_project] master: de-clutter (e9be98075a)

Wed Oct 7 06:40:00 PDT 2020

Hi Graeme,

It's just a simple call to the libtbx.clean_clutter script. But with the 
path set explicitly so it only works for this clone of the repo.

Rob

[hook "precommit"]
     cmdline = 
C:\\Users\\Oeffner\\Work\\Phenix\\phenix-installer-dev-3981-intel-windows-x86_64\\build\\bin\\libtbx.clean_clutter.bat
     wait = true
     show = true

On 07-10-2020 14:33, Winter, Graeme (DLSLtd,RAL,LSCI) wrote:
> Hi Rob,
>
> No worries - the deluge of commits last night with the same fricken 
> message have made my hyper sensitive and I have had a pet hate of 
> clean clutter for a long while, and your commit happened to come along 
> while I had it in my head
>
> I really think universal pre-commit hooks would be _a good thing_
>
> if you wanted to circulate the hook in question you may also help 
> others… though I seem to recall there are some who dislike things like 
> pre-commit hooks as somehow impinging on their freedom or similar…
>
> Cheers Graeme
>
>> On 7 Oct 2020, at 14:23, Robert Oeffner <rdo20 at cam.ac.uk 
>> <mailto:rdo20 at cam.ac.uk>> wrote:
>>
>> Sorry about the noise in the commit history. I have now put a 
>> pre-commit hook in my git settings that runs clean_clutter on my 
>> clone of the cctbx repo.
>>
>> Rob
>>
>>
>> On 07-10-2020 13:36, Winter, Graeme (DLSLtd,RAL,LSCI) wrote:
>>> Hi Folks
>>>
>>> Would anyone be offended if we had a pre-commit hook which ran the 
>>> clutter / unused imports tests to stop the history fulling up with 
>>> clean clutter commits?
>>>
>>> If clutter is important, probably should not let it in in the first 
>>> place?
>>>
>>> I’m not suggesting anything extreme like black, like we use for 
>>> dxtbx and dials, just running the tools that developers are supposed 
>>> to run before commits
>>>
>>> Cheers Graeme
>>>
>>>> Begin forwarded message:
>>>>
>>>> *From: *CCTBX commit <diamondlightsource.jenkins at GMAIL.COM 
>>>> <mailto:diamondlightsource.jenkins at GMAIL.COM>>
>>>> *Subject: **[git/cctbx_project] master: de-clutter (e9be98075a)*
>>>> *Date: *7 October 2020 at 12:56:50 BST
>>>> *To: *CCTBX-COMMIT at JISCMAIL.AC.UK <mailto:CCTBX-COMMIT at JISCMAIL.AC.UK>
>>>> *Reply-To: *cctbxbb at PHENIX-ONLINE.ORG 
>>>> <mailto:cctbxbb at PHENIX-ONLINE.ORG>
>>>>
>>>> Repository : https://github.com/cctbx/cctbx_project/ 
>>>> <https://github.com/cctbx/cctbx_project/>
>>>> On branch  : master
>>>> Link       : 
>>>> https://github.com/cctbx/cctbx_project/commit/e9be98075a31f4584f1eca41f9eba5e408d0cb8f
>>>>
>>>> ------------------------------------------------------------------------
>>>>
>>>>
>>>> commit e9be98075a31f4584f1eca41f9eba5e408d0cb8f
>>>> Author: Robert Oeffner <rdo20 at cam.ac.uk <mailto:rdo20 at cam.ac.uk>>
>>>> Date:   Wed Oct 7 12:56:50 2020 +0100
>>>>
>>>>     de-clutter
>>>>
>>>>
>>>> ------------------------------------------------------------------------
>>>>
>>>>
>>>> e9be98075a31f4584f1eca41f9eba5e408d0cb8f
>>>> cctbx/miller/__init__.py | 0
>>>> 1 file changed, 0 insertions(+), 0 deletions(-)
>>>>
>>>>
>>>> ------------------------------------------------------------------------
>>>>
>>>> To unsubscribe from the CCTBX-COMMIT list, click the following link:
>>>> https://www.jiscmail.ac.uk/cgi-bin/WA-JISC.exe?SUBED1=CCTBX-COMMIT&A=1
>>>>
>>>
>>>
>>> -- 
>>>
>>> This e-mail and any attachments may contain confidential, copyright 
>>> and or privileged material, and are for the use of the intended 
>>> addressee only. If you are not the intended addressee or an 
>>> authorised recipient of the addressee please notify us of receipt by 
>>> returning the e-mail and do not use, copy, retain, distribute or 
>>> disclose the information in or attached to the e-mail.
>>> Any opinions expressed within this e-mail are those of the 
>>> individual and not necessarily of Diamond Light Source Ltd.
>>> Diamond Light Source Ltd. cannot guarantee that this e-mail or any 
>>> attachments are free from viruses and we cannot accept liability for 
>>> any damage which you may sustain as a result of software viruses 
>>> which may be transmitted in or with the message.
>>> Diamond Light Source Limited (company no. 4375679). Registered in 
>>> England and Wales with its registered office at Diamond House, 
>>> Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 
>>> 0DE, United Kingdom
>>>
>>>
>>> _______________________________________________
>>> cctbxbb mailing list
>>> cctbxbb at phenix-online.org
>>> http://phenix-online.org/mailman/listinfo/cctbxbb
>> -- 
>> Robert Oeffner, Ph.D.
>> Research Associate, The Read Group
>> Department of Haematology,
>> Cambridge Institute for Medical Research
>> University of Cambridge
>> Cambridge Biomedical Campus
>> The Keith Peters Building
>> Hills Road
>> Cambridge CB2 0XY
>> www.cimr.cam.ac.uk/investigators/read/index.html
>> tel: +44(0)1223 763234
>>
>> <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> 
>> 	Virus-free. www.avg.com 
>> <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> 
>>
>>
>
> -- 
>
> This e-mail and any attachments may contain confidential, copyright 
> and or privileged material, and are for the use of the intended 
> addressee only. If you are not the intended addressee or an authorised 
> recipient of the addressee please notify us of receipt by returning 
> the e-mail and do not use, copy, retain, distribute or disclose the 
> information in or attached to the e-mail.
> Any opinions expressed within this e-mail are those of the individual 
> and not necessarily of Diamond Light Source Ltd.
> Diamond Light Source Ltd. cannot guarantee that this e-mail or any 
> attachments are free from viruses and we cannot accept liability for 
> any damage which you may sustain as a result of software viruses which 
> may be transmitted in or with the message.
> Diamond Light Source Limited (company no. 4375679). Registered in 
> England and Wales with its registered office at Diamond House, Harwell 
> Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United 
> Kingdom
>
-- 
Robert Oeffner, Ph.D.
Research Associate, The Read Group
Department of Haematology,
Cambridge Institute for Medical Research
University of Cambridge
Cambridge Biomedical Campus
The Keith Peters Building
Hills Road
Cambridge CB2 0XY
www.cimr.cam.ac.uk/investigators/read/index.html
tel: +44(0)1223 763234

-- 
This email has been checked for viruses by AVG.
https://www.avg.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://phenix-online.org/pipermail/cctbxbb/attachments/20201007/080e5889/attachment.htm>