Hi Radi,<div><br></div><div><meta charset="utf-8"><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
<br class="Apple-interchange-newline">1.) The SONAME and SOVERSION is missing from the shared libraries. I'm<br>attaching a patch that can fix this for GNU/Linux. That produces files<br>like this:<br></blockquote></div>
<div><br></div><div>Could you re-do the patch to reduce repetitive code?</div><div><br></div><div>E.g.</div><div><br></div><div><div>-if (env_etc.static_libraries): builder = envlm.StaticLibrary</div><div>-else: � � � � � � � � � � � � �builder = envlm.SharedLibrary</div>
<div>+if (env_etc.static_libraries):</div><div>+ �builder = envlm.StaticLibrary</div><div>+else:</div><div>+ �if hasattr(envlm, 'VersionedSharedLibrary'):</div><div>+ � �builder = envlm.VersionedSharedLibrary</div>
<div>+ �else:</div><div>+ � �builder = envlm.SharedLibrary</div><div>+</div></div><div><br></div><div>builder = env_etc.get_library_builder(env=envlm)</div><div><br></div><div>with the currently repeated code centralized in libtbx/SConscript under</div>
<div><br></div><div>def�get_library_builder(env):</div><meta charset="utf-8"><div><br>If you send me your sourceforge user name I'll enable svn write permission for you, so that you can check in the patch directly.</div>
<div><div class="gmail_quote"><div>�</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
2.) PyCifRW: I had to remove it from the sources because it ain't free<br>
software because of some lines in their license. It wasn't accepted to<br>
Fedora because of that, so I guess I can forget Debian either.<br></blockquote><div><br></div><div>We don't depend on PyCifRW anymore. Instead we are now using iotbx.cif;</div><div><a href="http://cctbx.sf.net/iotbx_cif/">http://cctbx.sf.net/iotbx_cif/</a></div>
<div>�</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
3.) In your changelog I read you wanna get rid of the "from __future__<br>
import division" and change to "python -Qnew". This would be a problem<br>
for me, because than I couldn't use it from sys.path anymore. I have a<br>
Django project at work that imports some cctbx modules directly from<br>
pythonpath. And I can't really call "cctbx.python" for that, otherwise I<br>
would have to patch my Apache and mod_wsgi, respectively cctbx.<br></blockquote><div><br></div><div>When you copy .py files into the /usr directories, could you automatically insert</div><div>from __future__ import division</div>
<div>as the first line of all .py files?</div><div>�</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Wouldn't it be better to install all python modules to the standard<br>
python location of the Distribution than making dispatchers with<br>
hardcoded paths?</blockquote><div><br></div><div>I think Luc Bourhis is trying to work out support for relative paths.</div><div>�</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Also, when the libraries, headers and python stuff<br>
would be in their standard location, everyone could just import it from<br>
anywhere?<br></blockquote><div><br></div><div>This question has been asked several times before. It would indeed be good to have optional support for something that works like "python setup.py install". I'm not sure what's the best way to implement this. Maybe start with the scripts that you have already? Would it make sense to check them in under an new directory? (Note that we already have rpmbuild at the top level; does this help in any way?)</div>
<div><br></div><div>The libtbx/configure framework is designed to avoid copies of Python sources. If you run "python setup.py install" copies are made. This is extremely confusing in development. I.e. we really need to keep the libtbx/configure framework, but it would be good to also have scripts that copy into the /usr directories for needs like yours.</div>
<div><br></div><div>Ralf</div><div><br></div></div></div>