<div class="gmail_extra">Dear Ralf,</div><div class="gmail_extra"><br></div><div class="gmail_extra">you're quite right! 狢 was looking at my basis along with the lattice which lead me to think that the two systems should be equivalent when indeed the lattices are not!</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Thanks for pointing this out.</div><div class="gmail_extra"><br></div><div class="gmail_extra">I'll get back to you once I'm ready with a version for the repository.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Best,</div><div class="gmail_extra">-Martin</div><div class="gmail_extra"><br><div class="gmail_quote">On 24 April 2012 20:42, Ralf Grosse-Kunstleve <span dir="ltr"><<a href="mailto:rwgrosse-kunstleve@lbl.gov" target="_blank">rwgrosse-kunstleve@lbl.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Martin,<div><br></div><div>Based on</div><div><br></div><div>iotbx.lattice_symmetry --unit_cell="4.630811 4.630811 4.630811 90 90 90"</div>
<div><br></div><div>and</div><div><br></div><div>iotbx.lattice_symmetry --unit_cell="3.27448 5.67156 5.67156 99.5941 106.779 90"</div>
<div><br></div><div>the first unit cell is (obviously) cubic, the second is only monoclinic. Even with</div><div><br></div><div>iotbx.lattice_symmetry --unit_cell="3.27448 5.67156 5.67156 99.5941 106.779 90" --delta=20</div>
<div><br></div><div>it only comes back as orthorhombic.</div><div><br></div><div>Is this what you expect?</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Ralf</div></font></span><div class="HOEnZb"><div class="h5">
<div><br></div><div><br></div><div><br><div class="gmail_quote">On Tue, Apr 24, 2012 at 10:57 AM, Martin Uhrin <span dir="ltr"><<a href="mailto:martin.uhrin.10@ucl.ac.uk" target="_blank">martin.uhrin.10@ucl.ac.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra">Dear cctbxers,</div><div class="gmail_extra"><br></div><div class="gmail_extra">I've finally found the time to play around with a C++ version of the KG algorithm and I've come across a result I don't understand. 狢've tried both David's C++ and the cctbx python niggli_cell() implementations and they both give the roughly the same answer.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">I'm reducing the following cell with two, equivalent, representations (a, b, c, alpha, beta, gamma):</div><div class="gmail_extra"><br></div><div class="gmail_extra">
Before:</div><div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_extra">1: 4.630811 � 4.630811 � 4.630811 � � � � 90 � � � � 90 � � � � 90</div><div class="gmail_extra">2:�3.27448 � � 5.67156 � �5.67156 � � � � � 99.5941 106.779 90</div>
<div><br></div><div>After:</div><div><br></div><div>1:�4.63081 � �4.63081 � �4.63081 � �90 � � � � �90 �90</div><div>2:�3.27448 � �5.67154 � �5.67156 � �99.5941 �90 � 106.778</div><div><br></div><div>Looking at the trace, cell 1 undergoes step 3 and finishes while cell 2 undergoes steps 2, 3, 7 and 4.</div>
<div><br></div></div><div class="gmail_extra">Does anyone know why these haven't converged to the same cell?</div><div class="gmail_extra"><br></div><div class="gmail_extra">Many thanks,</div><div class="gmail_extra">
-Martin</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On 23 March 2012 17:12, Ralf Grosse-Kunstleve <span dir="ltr"><<a href="mailto:rwgrosse-kunstleve@lbl.gov" target="_blank">rwgrosse-kunstleve@lbl.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Martin,<div>Let me know if you need svn write access to check in your changes. All I need is your sourceforge user id.</div>
<div><span><font color="#888888">Ralf</font></span><div><div><br><br><div class="gmail_quote">On Fri, Mar 23, 2012 at 3:35 AM, Martin Uhrin <span dir="ltr"><<a href="mailto:martin.uhrin.10@ucl.ac.uk" target="_blank">martin.uhrin.10@ucl.ac.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Dear David and Rolf,<div><br></div><div>thank you for your encouragement.</div><div><br></div><div>David: I'm more than happy to port your implementation to cctbx if you're happy with this. 𤪻f course I don't want to step on your toes so if you'd rather do it yourself (or not at all) that's cool.</div>
<div><br></div><div>There may be some licensing issues to sort out as it looks like cctbx has a custom (non戹iral) license but the BSD license is likely compatible.</div><div><br></div><div>On first impression I think a new class would be the way to go but I'd have to look at the two algorithms in greater detail to be sure.</div>
<div><br></div><div>All the best,</div><div>-Martin<div><div><br><br><div class="gmail_quote">On 22 March 2012 22:00, Ralf Grosse-Kunstleve <span dir="ltr"><<a href="mailto:rwgrosse-kunstleve@lbl.gov" target="_blank">rwgrosse-kunstleve@lbl.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Martin,<div>You're very welcome to add a C++ version of the Krivy-Gruber algorithm to cctbx if that's what you had in mind.</div>
<div>I'm not sure what's better, generalizing the fast-minimum-reduction code, or just having an independent implementation.</div><span><font color="#888888">
</font></span><div><span><font color="#888888">Ralf<br><br></font></span><div class="gmail_quote"><div>On Thu, Mar 22, 2012 at 2:24 PM, Martin Uhrin <span dir="ltr"><<a href="mailto:martin.uhrin.10@ucl.ac.uk" target="_blank">martin.uhrin.10@ucl.ac.uk</a>></span> wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Dear Cctbx community,<div><br></div><div>Firstly I'd like to say thank you to Rolf, Nicholas and Paul for their expertly thought through implementation of the reduced cell algorithm. 狢've found it to be extremely useful for my work.</div>
<div><br></div><div>My code is all in C++ and I'd like to be able to use the Krivy-Gruber algorithm. 瓱y understanding is that only the reduced�(Buerger)抦nit cell algorithm is implemented in C++ [1] which guarantees shortest lengths but not unique angles. 硓rom my understanding the Krivy-Gruber would also guarantee me抦niqueness䰄f unit cell angles, however this is only implemented in Python [2]. 䒷orry to be so verbose, I just wanted to check that I was on the right page.</div>
<div><br></div><div>Would it be possible for me to implement the Krivy-Gruber in C++ by adding in the epsilon_relative to the parameter and following the procedure found in the python version?</div><div><br></div><div>Many thanks,</div>
<div>-Martin</div><div><br></div><div>[1]�<a href="http://cctbx.sourceforge.net/current/c_plus_plus/classcctbx_1_1uctbx_1_1fast__minimum__reduction.html" target="_blank">http://cctbx.sourceforge.net/current/c_plus_plus/classcctbx_1_1uctbx_1_1fast__minimum__reduction.html</a></div>
<div>[2]�<a href="http://cctbx.sourceforge.net/current/python/cctbx.uctbx.krivy_gruber_1976.html" target="_blank">http://cctbx.sourceforge.net/current/python/cctbx.uctbx.krivy_gruber_1976.html</a></div><span><font color="#888888"><div>
<br></div><div><br clear="all">
<div><br></div>-- <br><span style="border-collapse:collapse;color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px">Martin Uhrin � � � � � � � � � � � � � � � � � � � � � � � � �Tel: <a href="tel:%2B44%20207%20679%203466" value="+442076793466" target="_blank">+44 207 679 3466</a><br>
Department of Physics & Astronomy� � � � � � � Fax:<a href="tel:%2B44%20207%20679%200595" value="+442076790595" target="_blank">+44 207 679 0595</a><br>
University College London � � � � � � � � � � � �<a href="mailto:martin.uhrin.10@ucl.ac.uk" style="color:rgb(0,0,204)" target="_blank">martin.uhrin.10@ucl.ac.uk</a><br>Gower St, London, WC1E 6BT, U.K.� � � ��<a href="http://www.cmmp.ucl.ac.uk/" style="color:rgb(0,0,204)" target="_blank">http://www.cmmp.ucl.ac.uk</a></span><br>
</div>
</font></span><br></div></div><div>_______________________________________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/mailman/listinfo/cctbxbb</a><br>
<br></div></blockquote></div><br></div>
<br>_______________________________________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/mailman/listinfo/cctbxbb</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><span style="border-collapse:collapse;color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px">Martin Uhrin � � � � � � � � � � � � � � � � � � � � � � � � �Tel: <a href="tel:%2B44%20207%20679%203466" value="+442076793466" target="_blank">+44 207 679 3466</a><br>
Department of Physics & Astronomy� � � � � � � Fax:<a href="tel:%2B44%20207%20679%200595" value="+442076790595" target="_blank">+44 207 679 0595</a><br>University College London � � � � � � � � � � � �<a href="mailto:martin.uhrin.10@ucl.ac.uk" style="color:rgb(0,0,204)" target="_blank">martin.uhrin.10@ucl.ac.uk</a><br>
Gower St, London, WC1E 6BT, U.K.� � � ��<a href="http://www.cmmp.ucl.ac.uk/" style="color:rgb(0,0,204)" target="_blank">http://www.cmmp.ucl.ac.uk</a></span><br>
</div></div></div>
<br>_______________________________________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/mailman/listinfo/cctbxbb</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/mailman/listinfo/cctbxbb</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><span style="border-collapse:collapse;color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px">Martin Uhrin � � � � � � � � � � � � � � � � � � � � � � � � �Tel: <a href="tel:%2B44%20207%20679%203466" value="+442076793466" target="_blank">+44 207 679 3466</a><br>
Department of Physics & Astronomy� � � � � � � Fax:<a href="tel:%2B44%20207%20679%200595" value="+442076790595" target="_blank">+44 207 679 0595</a><br>University College London � � � � � � � � � � � �<a href="mailto:martin.uhrin.10@ucl.ac.uk" style="color:rgb(0,0,204)" target="_blank">martin.uhrin.10@ucl.ac.uk</a><br>
Gower St, London, WC1E 6BT, U.K.� � � ��<a href="http://www.cmmp.ucl.ac.uk/" style="color:rgb(0,0,204)" target="_blank">http://www.cmmp.ucl.ac.uk</a></span><br>
</div>
</div></div><br>_______________________________________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/mailman/listinfo/cctbxbb</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/mailman/listinfo/cctbxbb</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><span style="border-collapse:collapse;color:rgb(136,136,136);font-family:arial,sans-serif;font-size:13px">Martin Uhrin � � � � � � � � � � � � � � � � � � � � � � � � �Tel: +44 207 679 3466<br>
Department of Physics & Astronomy� � � � � � � Fax:+44 207 679 0595<br>University College London � � � � � � � � � � � �<a href="mailto:martin.uhrin.10@ucl.ac.uk" style="color:rgb(0,0,204)" target="_blank">martin.uhrin.10@ucl.ac.uk</a><br>
Gower St, London, WC1E 6BT, U.K.� � � ��<a href="http://www.cmmp.ucl.ac.uk/" style="color:rgb(0,0,204)" target="_blank">http://www.cmmp.ucl.ac.uk</a></span><br>
</div>