<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>indeed - sorry that I forgot to mention,<div><br></div><div>Oleg.<br><br><div><hr id="stopSpelling">From: rgildea@gmail.com<br>Date: Mon, 4 Nov 2013 16:39:21 +0000<br>To: cctbxbb@phenix-online.org<br>Subject: Re: [cctbxbb] compiler warning in dxtbx<br><br>Doesn't line 279 also have the same problem?<div><br></div><div><div><br></div><div> /** @returns True/False This and the other frame are different */</div><div> bool operator!=(const PanelFrame &other) const {</div><div> return *this != other;</div><div> }</div><div><br></div><div>Cheers,</div><div><br></div><div>Richard</div><div><br></div><div><div>On 4 Nov 2013, at 16:35, Oleg Dolomanov <<a href="mailto:oleg@olexsys.org">oleg@olexsys.org</a>> wrote:</div><br class="ecxApple-interchange-newline"><blockquote><div class="ecxhmmessage" style="font-size:12pt;font-family:Calibri;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;orphans:2;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;widows:2;word-spacing:0px;"><div dir="ltr">It appears to be corrected,<div><br>Cheers, Oleg.</div><div><br><div><hr id="ecxstopSpelling">From: <a href="mailto:Graeme.Winter@diamond.ac.uk">Graeme.Winter@diamond.ac.uk</a><br>To: <a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><br>Date: Mon, 4 Nov 2013 16:28:47 +0000<br>Subject: Re: [cctbxbb] compiler warning in dxtbx<br><br><div class="ecxWordSection1"><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">[gw56@ws133 model]$ svn diff</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">Index: panel.h</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">===================================================================</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">--- panel.h (revision 18525)</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">+++ panel.h (working copy)</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">@@ -375,7 +375,7 @@</span></div><p class="ecxMsoNormal" style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> </span></p><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> /** @returns True/False this is not the same as the other */</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> bool operator!=(const PanelBase &other) const {</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">- return *this != other;</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">+ return !(*this == other);</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> }</span></div><p class="ecxMsoNormal" style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> </span></p><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> protected:</span></div><p class="ecxMsoNormal" style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> </span></p><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">built fine for me on RHEL6, assume that this is a sound definition as not recursive�</span></div><p class="ecxMsoNormal" style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> </span></p><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">[gw56@ws133 model]$ svn commit -m "Fix of panel to prevent recursive definition"</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">Sending model/panel.h</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">Transmitting file data .</span></div><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">Committed revision 18527.</span></div><p class="ecxMsoNormal" style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> </span></p><div style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);">Cheerio, Graeme</span></div><p class="ecxMsoNormal" style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> </span></p><p class="ecxMsoNormal" style="padding:0px;"><span style="font-size:11pt;font-family:Calibri, sans-serif;color:rgb(31, 73, 125);"> </span></p><div><div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(181, 196, 223);padding:3pt 0cm 0cm;"><div style="padding:0px;"><b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma, sans-serif;">From:</span></b><span lang="EN-US" style="font-size:10pt;font-family:Tahoma, sans-serif;"><span class="ecxApple-converted-space"> </span><a href="mailto:cctbxbb-bounces@phenix-online.org">cctbxbb-bounces@phenix-online.org</a> [mailto:cctbxbb-<a href="mailto:bounces@phenix-online.org">bounces@phenix-online.org</a>]<span class="ecxApple-converted-space"> </span><b>On Behalf Of<span class="ecxApple-converted-space"> </span></b>Oleg Dolomanov<br><b>Sent:</b><span class="ecxApple-converted-space"> </span>04 November 2013 16:21<br><b>To:</b><span class="ecxApple-converted-space"> </span><a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><br><b>Subject:</b><span class="ecxApple-converted-space"> </span>[cctbxbb] compiler warning in dxtbx</span></div></div></div><p class="ecxMsoNormal" style="padding:0px;"> </p><div><div style="padding:0px;"><span style="font-family:Calibri, sans-serif;">Hi guys,</span></div><div><p class="ecxMsoNormal" style="padding:0px;"><span style="font-family:Calibri, sans-serif;"> </span></p></div><div><div style="padding:0px;"><span style="font-family:Calibri, sans-serif;">there was big change in dxtbx/model/panel.h on the 30th of October (r18499) and apparently the != operator became recursive by calling itself rather than the == operator (line 378) - whoever is responsible - please check/fix,</span></div></div><div><p class="ecxMsoNormal" style="padding:0px;"><span style="font-family:Calibri, sans-serif;"> </span></p></div><div><div style="padding:0px;"><span style="font-family:Calibri, sans-serif;">Cheers,</span></div></div><div><p class="ecxMsoNormal" style="padding:0px;"><span style="font-family:Calibri, sans-serif;"> </span></p></div><div><div style="padding:0px;"><span style="font-family:Calibri, sans-serif;">Oleg.</span></div></div></div></div><br><p align="justify" style="padding:0px;"> </p><div style="padding:0px;">-- </div><div style="padding:0px;">This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.<br>Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.<span class="ecxApple-converted-space"> </span><br>Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.<br>Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom<br> </div><br><br>_______________________________________________ cctbxbb mailing list <a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a> <a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/mailman/listinfo/cctbxbb</a></div></div></div>_______________________________________________<br>cctbxbb mailing list<br><a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><br><a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/mailman/listinfo/cctbxbb</a></div></blockquote></div><br></div><br>_______________________________________________
cctbxbb mailing list
cctbxbb@phenix-online.org
http://phenix-online.org/mailman/listinfo/cctbxbb</div></div> </div></body>
</html>