<div dir="ltr">On Sun, Jun 22, 2014 at 10:50 AM, <span dir="ltr"><<a href="mailto:Graeme.Winter@diamond.ac.uk" target="_blank">Graeme.Winter@diamond.ac.uk</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In cctbx_project/iotbx/pdb/multimer_reconstruction.py there is a dependency on Phenix<br>
<br>
from phenix.command_line.simple_ncs_from_pdb import simple_ncs_from_pdb<br>
from phenix.command_line.simple_ncs_from_pdb import ncs_master_params<br>
<br>
Please could someone remove this? I just had a look at cleaning things up so that this was encapsulated but was not obvious and figured risk of breaking was more substantial.<br></blockquote><div><br></div><div>Sorry, this should not have happened. I've checked in a fix (I hope). The usual solution is to move such imports inline; as far as I'm concerned if this happens again you would not be out of line to do so unilaterally.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This is breaking our nightly build tests at Diamond as we don’t check out phenix :o(<br></blockquote><div><br></div><div>It's also breaking the CCTBX-specific tests in our nightly builds, since these are deliberately run without the phenix modules. I wasn't paying attention to these yesterday, unfortunately.</div>
<div><br></div><div>-Nat</div></div></div></div>