<div dir="ltr">Rob,<div><br></div><div>Just as a general thing, "new" statements in C++ need to be paired with "delete" statements (delete pk, delete a_sum, and delete akml). Unless this is done there will be a memory leak. </div><div><br></div><div>Nick</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Nicholas K. Sauter, Ph. D.<br>Senior Scientist, Molecular Biophysics & Integrated Bioimaging Division<div>Lawrence Berkeley National Laboratory<br>1 Cyclotron Rd., Bldg. 33R0345<br>Berkeley, CA 94720<br>(510) 486-5713<br></div></div></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Tue, Apr 11, 2017 at 3:31 AM, CCTBX Commit via DLS Jenkins <span dir="ltr"><<a href="mailto:graeme.winter@gmail.com" target="_blank">graeme.winter@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><tt>Repository : ssh://<a href="http://g18-sc-serv-04.diamond.ac.uk/cctbx" target="_blank">g18-sc-serv-04.diamond.<wbr>ac.uk/cctbx</a><br>On branch : master<br><br><hr><br><br>commit a31eb2bf0d5bb129425bb759466f45<wbr>622c773fd4<br>Author: Robert Oeffner <<a href="mailto:rdo20@cam.ac.uk" target="_blank">rdo20@cam.ac.uk</a>><br>Date: Tue Apr 11 11:31:24 2017 +0100<br><br> Replacing illegal C++ code with proper dynamic array allocation.<br><br><br><hr><br><br>a31eb2bf0d5bb129425bb759466f45<wbr>622c773fd4<br> scitbx/lbfgs.h | 6 +++---<br> 1 file changed, 3 insertions(+), 3 deletions(-)<br><br>diff --git a/scitbx/lbfgs.h b/scitbx/lbfgs.h<br>index 41be8e8cc..f0000143d 100755<br><tt style="color:#800">--- a/scitbx/lbfgs.h</tt><br><tt style="color:#080">+++ b/scitbx/lbfgs.h</tt><br>@@ -917,9 +917,9 @@ namespace lbfgs {<br> int info = 5;<br> brackt = false;<br> FloatType sxnorm = std::sqrt(ddot(SizeType(n), sx, sx));<br><tt style="color:#800">- FloatType pk[n];</tt><br><tt style="color:#800">- FloatType a_sum[n];</tt><br><tt style="color:#800">- FloatType akm1[n];</tt><br><tt style="color:#080">+ FloatType* pk = new FloatType[n];</tt><br><tt style="color:#080">+ FloatType* a_sum = new FloatType[n];</tt><br><tt style="color:#080">+ FloatType* akm1 = new FloatType[n];</tt><br> for (SizeType i=0; i < n; i++) {<br> pk[i] = sx[i]/sxnorm;<br> akm1[i] = -gx[i]/sxnorm;<br></tt></div></blockquote></div><br></div>