<div dir="ltr">Hi Pavel, Rob,<div><br></div><div>I'd like to reiterate concern about freeing memory after allocating it with "new". Didn't find anything in this regard. More than 1 occasion in lbfgs.h file. Are we sure memory leak is not happening?</div><div><br></div><div>Best regards,</div><div>Oleg Sobolev. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 11, 2017 at 11:18 AM, R.D. Oeffner <span dir="ltr"><<a href="mailto:rdo20@cam.ac.uk" target="_blank">rdo20@cam.ac.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div style="font-size:10pt">
<p>There is now a fatal warning in libtbx/SConscript if gcc encounters variable length arrays as this is not portable code and we've had broken builds on more than one occasion due to this recently.</p>
<p>Rob</p>
<p> </p>
<p>On 11/04/2017 12:01, Pavel Afonine wrote:</p>
<blockquote type="cite" style="padding-left:5px;border-left:#1010ff 2px solid;margin-left:5px">
<pre>Hi Rob,
thanks for the fix. This is was Min's code (remember her from the past workshop?). I simply applied her patch without looking into it too much, and made sure all t96 pass.
Again, thanks for fixing it.
Pavel
On 4/11/17 03:48, R.D. Oeffner wrote:</pre>
<blockquote type="cite" style="padding-left:5px;border-left:#1010ff 2px solid;margin-left:5px">Hi Pavel, I have made a change to that file as it didn't compile on Windows. In fact I can't understand how it would compile with other compilers before as the syntax to me seemed illegal given that n is not known at compile time. I'm not sure how a dynamically created FloatType should be destroyed as I couldn't find any examples of that being done throughout this file. Rob</blockquote>
</blockquote>
<p> </p>
</div>
<br>______________________________<wbr>_________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" rel="noreferrer" target="_blank">http://phenix-online.org/<wbr>mailman/listinfo/cctbxbb</a><br>
<br></blockquote></div><br></div>