<div dir="ltr">Hi, sorry I thought things were good based on my local tests. However, it looks like we need to fix some compile errors on different platforms. I've reverted the change for now, but I'll be putting it back soon (probably later today) after we've done some more testing.<div><br></div><div><div>Regarding Graeme's original point: "simtbx, part of the core cctbx now, depends on dials. This means if you do not have a dials build your cctbx will be broken". This is untrue. A core cctbx build means you run bootstrap.py --builder=cctbx. You'll get 'cctbx', 'cbflib', 'scitbx', 'libtbx', 'iotbx', 'mmtbx', 'smtbx', 'dxtbx', 'gltbx', 'wxtbx'. This does means several packages in cctbx_project would not be configured. If instead you ran python /path/to/libtbx/configure.py cctbx in an empty folder, you would get a similar list of packages.</div></div><div><br></div><div>About dependencies, there is a circular dependency between xfel and dials. xfel depends on dials and dials depends on xfel. It's been there for a while. The root cause is dials.stills_process depends on xfel code, specifically xfel.mono_simulation. It would be nice to break this cycle, but it would involve shuffling a lot of code around. Instead, xfel is an optional dependency of dials and dials is a required dependency of xfel. simtbx will be an optional dependency of xfel.</div><div><br></div><div>If you'd like to see the dependency chains, use<br></div><div>libtbx.show_module_dependencies xfel<br></div><div>libtbx.show_module_dependencies dials<br></div><div>libtbx.show_module_dependencies cctbx<br></div><div><br></div><div>-Aaron</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 3, 2017 at 8:28 AM, James Holton <span dir="ltr"><<a href="mailto:jmholton@lbl.gov" target="_blank">jmholton@lbl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<br>
"simtbx" is the name we are giving to my diffraction image
simulation codes. You may or may not of heard of their standalone
versions as MLFSOM, fastBragg (now nanoBragg), nonBragg and
nearBragg. Nick and I thought the capability of creating absolutely
realistic diffraction data from a completely independent code base
would be an excellent way to generate test data for cctbx, dials,
phenix, and even third-party packages. There is also the idea of
fitting a simulation directly to diffraction images, which I have
had some success doing independently, but we hope this will work
better under cctbx. Until recently, all this was standalone c code,
with home pages here:<br>
<br>
<a class="m_9144792529750943463moz-txt-link-freetext" href="http://bl831.als.lbl.gov/~jamesh/mlfsom/" target="_blank">http://bl831.als.lbl.gov/~<wbr>jamesh/mlfsom/</a><br>
<a class="m_9144792529750943463moz-txt-link-freetext" href="http://bl831.als.lbl.gov/~jamesh/nanoBragg/" target="_blank">http://bl831.als.lbl.gov/~<wbr>jamesh/nanoBragg/</a><br>
<a class="m_9144792529750943463moz-txt-link-freetext" href="http://bl831.als.lbl.gov/~jamesh/nearBragg/" target="_blank">http://bl831.als.lbl.gov/~<wbr>jamesh/nearBragg/</a><br>
<a class="m_9144792529750943463moz-txt-link-freetext" href="http://bl831.als.lbl.gov/~jamesh/nonBragg/" target="_blank">http://bl831.als.lbl.gov/~<wbr>jamesh/nonBragg/</a><br>
<br>
I have spent the bulk of my time for three months trying to wire
these codes into the boost/Python framework of cctbx. I put
docstrings into every single one of my objects, but since I am new
to Python I don't know where people look for documentation.<br>
<br>
Again, sorry this broke everything. It's been in there since
February and I was surprised to find that a new developer here
couldn't access it. This is why I've been asking so many questions
about tests I should perform before checking things in, but
apparently it was all for naught.<span class="HOEnZb"><font color="#888888"><br>
<br>
-James</font></span><div><div class="h5"><br>
<br>
<div class="m_9144792529750943463moz-cite-prefix">On 5/3/2017 7:57 AM, Pavel Afonine
wrote:<br>
</div>
<blockquote type="cite">
Same questions here as Markus asked.. What is simtbx? First time
hear about it. How cctbx can benefit from it?<br>
Pavel<br>
<br>
<div class="m_9144792529750943463moz-cite-prefix">On 5/3/17 07:53, <a class="m_9144792529750943463moz-txt-link-abbreviated" href="mailto:markus.gerstel@diamond.ac.uk" target="_blank">markus.gerstel@diamond.ac.uk</a> wrote:<br>
</div>
<blockquote type="cite">
<div class="m_9144792529750943463WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Hi
Nick,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Sorry,
outsider perspective here. I don’t know what simtbx does
or is supposed to do.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">What
is the benefit of having code in a repository that,
according to your earlier mail, is explicitly not used in
the project?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Or
more bluntly: We (and ccp4) distribute dials and, as part
of it, the cctbx_project repository.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Why
should we ship dead code?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">-Markus<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><a name="m_9144792529750943463__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></a></p>
<span></span>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif" lang="EN-US">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif" lang="EN-US"> <a class="m_9144792529750943463moz-txt-link-abbreviated" href="mailto:cctbxbb-bounces@phenix-online.org" target="_blank">cctbxbb-bounces@phenix-online.<wbr>org</a>
[<a class="m_9144792529750943463moz-txt-link-freetext" href="mailto:cctbxbb-bounces@phenix-online.org" target="_blank">mailto:cctbxbb-bounces@<wbr>phenix-online.org</a>]
<b>On Behalf Of </b>Nicholas Sauter<br>
<b>Sent:</b> 03 May 2017 15:52<br>
<b>To:</b> cctbx mailing list <a class="m_9144792529750943463moz-txt-link-rfc2396E" href="mailto:cctbxbb@phenix-online.org" target="_blank"><cctbxbb@phenix-online.org></a><br>
<b>Subject:</b> Re: [cctbxbb] simtbx<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Markus,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">We want option c. simtbx should be
in the cctbx_project directory. No separate git
repository. We need to double check we've gotten all
the files in cctbx_project, then remove them from the
separate repo. James, could you look into this?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Nick<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><br clear="all">
<u></u><u></u></p>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal">Nicholas K. Sauter, Ph.
D.<br>
Senior Scientist, Molecular Biophysics
& Integrated Bioimaging Division<u></u><u></u></p>
<div>
<p class="MsoNormal">Lawrence Berkeley
National Laboratory<br>
1 Cyclotron Rd., Bldg. 33R0345<br>
Berkeley, CA 94720<br>
<a href="tel:(510)%20486-5713" value="+15104865713" target="_blank">(510) 486-5713</a><u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Wed, May 3, 2017 at 7:49 AM, <<a href="mailto:markus.gerstel@diamond.ac.uk" target="_blank">markus.gerstel@diamond.ac.uk</a>>
wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal"><span style="color:#1f497d">Hi James,</span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d">It looks that you now have
two separate places where simtbx code is kept.
One is in the simtbx repository, where you fixed
the sign earlier, and the other one is in the
cctbx repository, where you just now fixed it
again.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d">Simtbx repo: <a href="https://github.com/dials/simtbx" target="_blank">https://github.com/dials/<wbr>simtbx</a></span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d">Simtbx folder in cctbx
repo: <a href="https://github.com/cctbx/cctbx_project/tree/master/simtbx" target="_blank">
https://github.com/cctbx/<wbr>cctbx_project/tree/master/<wbr>simtbx</a> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d">I guess suppose there are
three options here:</span><u></u><u></u></p>
<p class="m_9144792529750943463m-2651995399140751371msolistparagraph"><span style="color:#1f497d">a.</span><span style="font-size:7.0pt;color:#1f497d"> </span><span style="color:#1f497d">move simtbx into the
module directory, add simtbx to the bootstrap
script so it is initialised correctly.</span><u></u><u></u></p>
<p class="m_9144792529750943463m-2651995399140751371msolistparagraph"><span style="color:#1f497d">b.</span><span style="font-size:7.0pt;color:#1f497d"> </span><span style="color:#1f497d">leave simtbx inside the
cctbx_project directory and repository, but as
its own git repository (using git submodule)</span><u></u><u></u></p>
<p class="m_9144792529750943463m-2651995399140751371msolistparagraph"><span style="color:#1f497d">c.</span><span style="font-size:7.0pt;color:#1f497d"> </span><span style="color:#1f497d">leave simtbx inside the
cctbx_project directory, delete the separate git
repository</span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d">NB: This issue is
independent of resolving the dials-dependency
issue.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="color:#1f497d">-Markus</span><u></u><u></u></p>
<p class="MsoNormal"><a name="m_9144792529750943463_m_-2651995399140751371__MailEndCompose"><span style="color:#1f497d"> </span></a><u></u><u></u></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> <a href="mailto:cctbxbb-bounces@phenix-online.org" target="_blank">cctbxbb-bounces@phenix-online.<wbr>org</a>
[mailto:<a href="mailto:cctbxbb-bounces@phenix-online.org" target="_blank">cctbxbb-bounces@<wbr>phenix-online.org</a>]
<b>On Behalf Of </b>James Holton<br>
<b>Sent:</b> 03 May 2017 15:40<br>
<b>To:</b> Winter, Graeme (DLSLtd,RAL,LSCI)
<<a href="mailto:Graeme.Winter@Diamond.ac.uk" target="_blank">Graeme.Winter@Diamond.ac.uk</a>>;
<a href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a><br>
<b>Subject:</b> Re: [cctbxbb] simtbx</span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
Yesterday, Aaron and I were trying to set
things up so that simtbx would be available to
people who aren't James Holton. It's been
checked in and working for over a month now,
and only a few days ago I discovered that a
fresh "bootstrap" has a broken simtbx, despite
my "git status" telling me all my files are up
to date. I asked Aaron and Nick for help with
this.<br>
<br>
I thought what we did was make cctbx.xfel
depends on simtbx, since fitting simulations
to stills is the whole reason for porting my
stuff into python. <br>
<br>
I set up simtbx with a constructor that takes
a dxtbx detector as input, but does that make
it depend on dials? I did not expect that.<br>
<br>
Sorry, didn't mean to break anything! Would
much appreciate any help on this. <br>
<br>
-James<u></u><u></u></p>
<div>
<p class="MsoNormal">On
5/3/2017 1:41 AM, <a href="mailto:Graeme.Winter@Diamond.ac.uk" target="_blank">Graeme.Winter@Diamond.ac.uk</a>
wrote:<u></u><u></u></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi
Folks<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">We
have noticed that simtbx, part of the core
cctbx now, depends on dials<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">This
means if you do not have a dials build your
cctbx will be broken<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">This
is probably not the way we want things?<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">I
thought simtbx was a separate repo?<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Cheerio
Graeme<u></u><u></u></p>
<p> <u></u><u></u></p>
<p>-- <u></u><u></u></p>
<p>This e-mail and any attachments may contain
confidential, copyright and or privileged
material, and are for the use of the
intended addressee only. If you are not the
intended addressee or an authorised
recipient of the addressee please notify us
of receipt by returning the e-mail and do
not use, copy, retain, distribute or
disclose the information in or attached to
the e-mail.<br>
Any opinions expressed within this e-mail
are those of the individual and not
necessarily of Diamond Light Source Ltd. <br>
Diamond Light Source Ltd. cannot guarantee
that this e-mail or any attachments are free
from viruses and we cannot accept liability
for any damage which you may sustain as a
result of software viruses which may be
transmitted in or with the message.<br>
Diamond Light Source Limited (company no.
4375679). Registered in England and Wales
with its registered office at Diamond House,
Harwell Science and Innovation Campus,
Didcot, Oxfordshire, OX11 0DE, United
Kingdom<br>
<u></u><u></u></p>
</blockquote>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
</div>
<div>
<div>
<p> <u></u><u></u></p>
<p>-- <u></u><u></u></p>
<p>This e-mail and any attachments may contain
confidential, copyright and or privileged
material, and are for the use of the intended
addressee only. If you are not the intended
addressee or an authorised recipient of the
addressee please notify us of receipt by
returning the e-mail and do not use, copy,
retain, distribute or disclose the information
in or attached to the e-mail.<br>
Any opinions expressed within this e-mail are
those of the individual and not necessarily of
Diamond Light Source Ltd. <br>
Diamond Light Source Ltd. cannot guarantee that
this e-mail or any attachments are free from
viruses and we cannot accept liability for any
damage which you may sustain as a result of
software viruses which may be transmitted in or
with the message.<br>
Diamond Light Source Limited (company no.
4375679). Registered in England and Wales with
its registered office at Diamond House, Harwell
Science and Innovation Campus, Didcot,
Oxfordshire, OX11 0DE, United Kingdom<br>
<u></u><u></u></p>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
______________________________<wbr>_________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/<wbr>mailman/listinfo/cctbxbb</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
<br>
<fieldset class="m_9144792529750943463mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
cctbxbb mailing list
<a class="m_9144792529750943463moz-txt-link-abbreviated" href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a>
<a class="m_9144792529750943463moz-txt-link-freetext" href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/<wbr>mailman/listinfo/cctbxbb</a>
</pre>
</blockquote>
<br>
<br>
<fieldset class="m_9144792529750943463mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
cctbxbb mailing list
<a class="m_9144792529750943463moz-txt-link-abbreviated" href="mailto:cctbxbb@phenix-online.org" target="_blank">cctbxbb@phenix-online.org</a>
<a class="m_9144792529750943463moz-txt-link-freetext" href="http://phenix-online.org/mailman/listinfo/cctbxbb" target="_blank">http://phenix-online.org/<wbr>mailman/listinfo/cctbxbb</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>______________________________<wbr>_________________<br>
cctbxbb mailing list<br>
<a href="mailto:cctbxbb@phenix-online.org">cctbxbb@phenix-online.org</a><br>
<a href="http://phenix-online.org/mailman/listinfo/cctbxbb" rel="noreferrer" target="_blank">http://phenix-online.org/<wbr>mailman/listinfo/cctbxbb</a><br>
<br></blockquote></div><br></div>