<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Graeme,</p>
<p>It's just a simple call to the libtbx.clean_clutter script. But
with the path set explicitly so it only works for this clone of
the repo.</p>
<p>Rob<br>
</p>
<p>[hook "precommit"]<br>
cmdline =
C:\\Users\\Oeffner\\Work\\Phenix\\phenix-installer-dev-3981-intel-windows-x86_64\\build\\bin\\libtbx.clean_clutter.bat<br>
wait = true<br>
show = true<br>
</p>
<p><br>
</p>
<div class="moz-cite-prefix">On 07-10-2020 14:33, Winter, Graeme
(DLSLtd,RAL,LSCI) wrote:<br>
</div>
<blockquote type="cite"
cite="mid:05FCBCD4-7131-4B96-AAAD-921E384ADD8F@diamond.ac.uk">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Hi Rob,
<div class=""><br class="">
</div>
<div class="">No worries - the deluge of commits last night with
the same fricken message have made my hyper sensitive and I have
had a pet hate of clean clutter for a long while, and your
commit happened to come along while I had it in my head</div>
<div class=""><br class="">
</div>
<div class="">I really think universal pre-commit hooks would be
_a good thing_ </div>
<div class=""><br class="">
</div>
<div class="">if you wanted to circulate the hook in question you
may also help others… though I seem to recall there are some who
dislike things like pre-commit hooks as somehow impinging on
their freedom or similar… </div>
<div class=""><br class="">
</div>
<div class="">Cheers Graeme<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 7 Oct 2020, at 14:23, Robert Oeffner <<a
href="mailto:rdo20@cam.ac.uk" class=""
moz-do-not-send="true">rdo20@cam.ac.uk</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">
<p class="">Sorry about the noise in the commit history.
I have now put a pre-commit hook in my git settings
that runs clean_clutter on my clone of the cctbx repo.</p>
<p class="">Rob</p>
<p class=""><br class="">
</p>
<div class="moz-cite-prefix">On 07-10-2020 13:36,
Winter, Graeme (DLSLtd,RAL,LSCI) wrote:<br class="">
</div>
<blockquote type="cite"
cite="mid:42A183B8-495A-44E6-965C-B0E2DC931A92@diamond.ac.uk"
class="">
Hi Folks
<div class=""><br class="">
</div>
<div class="">Would anyone be offended if we had a
pre-commit hook which ran the clutter / unused
imports tests to stop the history fulling up with
clean clutter commits?</div>
<div class=""><br class="">
</div>
<div class="">If clutter is important, probably should
not let it in in the first place?</div>
<div class=""><br class="">
</div>
<div class="">I’m not suggesting anything extreme like
black, like we use for dxtbx and dials, just running
the tools that developers are supposed to run before
commits</div>
<div class=""><br class="">
</div>
<div class="">Cheers Graeme<br class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">Begin forwarded message:</div>
<br class="Apple-interchange-newline">
<div style="margin-top: 0px; margin-right: 0px;
margin-bottom: 0px; margin-left: 0px;"
class="">
<span style="font-family: -webkit-system-font,
"Helvetica Neue", Helvetica,
sans-serif;" class=""><b class="">From:
</b></span><span style="font-family:
-webkit-system-font, Helvetica Neue,
Helvetica, sans-serif;" class="">CCTBX
commit <<a
href="mailto:diamondlightsource.jenkins@GMAIL.COM"
class="" moz-do-not-send="true">diamondlightsource.jenkins@GMAIL.COM</a>><br
class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px;
margin-bottom: 0px; margin-left: 0px;"
class="">
<span style="font-family: -webkit-system-font,
"Helvetica Neue", Helvetica,
sans-serif;" class=""><b class="">Subject:
</b></span><span style="font-family:
-webkit-system-font, Helvetica Neue,
Helvetica, sans-serif;" class=""><b class="">[git/cctbx_project]
master: de-clutter (e9be98075a)</b><br
class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px;
margin-bottom: 0px; margin-left: 0px;"
class="">
<span style="font-family: -webkit-system-font,
"Helvetica Neue", Helvetica,
sans-serif;" class=""><b class="">Date:
</b></span><span style="font-family:
-webkit-system-font, Helvetica Neue,
Helvetica, sans-serif;" class="">7 October
2020 at 12:56:50 BST<br class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px;
margin-bottom: 0px; margin-left: 0px;"
class="">
<span style="font-family: -webkit-system-font,
"Helvetica Neue", Helvetica,
sans-serif;" class=""><b class="">To:
</b></span><span style="font-family:
-webkit-system-font, Helvetica Neue,
Helvetica, sans-serif;" class=""><a
href="mailto:CCTBX-COMMIT@JISCMAIL.AC.UK"
class="" moz-do-not-send="true">CCTBX-COMMIT@JISCMAIL.AC.UK</a><br
class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px;
margin-bottom: 0px; margin-left: 0px;"
class="">
<span style="font-family: -webkit-system-font,
"Helvetica Neue", Helvetica,
sans-serif;" class=""><b class="">Reply-To:
</b></span><span style="font-family:
-webkit-system-font, Helvetica Neue,
Helvetica, sans-serif;" class=""><a
href="mailto:cctbxbb@PHENIX-ONLINE.ORG"
class="" moz-do-not-send="true">cctbxbb@PHENIX-ONLINE.ORG</a><br
class="">
</span></div>
<br class="">
<div class="">
<div class=""><tt class="">Repository : <a
href="https://github.com/cctbx/cctbx_project/"
class="" moz-do-not-send="true">
https://github.com/cctbx/cctbx_project/</a><br
class="">
On branch : master<br class="">
Link : <a
href="https://github.com/cctbx/cctbx_project/commit/e9be98075a31f4584f1eca41f9eba5e408d0cb8f"
class="" moz-do-not-send="true">
https://github.com/cctbx/cctbx_project/commit/e9be98075a31f4584f1eca41f9eba5e408d0cb8f</a><br
class="">
<br class="">
<hr class="">
<br class="">
<br class="">
commit
e9be98075a31f4584f1eca41f9eba5e408d0cb8f<br
class="">
Author: Robert Oeffner <<a
href="mailto:rdo20@cam.ac.uk" class=""
moz-do-not-send="true">rdo20@cam.ac.uk</a>><br
class="">
Date: Wed Oct 7 12:56:50 2020 +0100<br
class="">
<br class="">
de-clutter<br class="">
<br class="">
<br class="">
<hr class="">
<br class="">
<br class="">
e9be98075a31f4584f1eca41f9eba5e408d0cb8f<br
class="">
cctbx/miller/__init__.py | 0<br class="">
1 file changed, 0 insertions(+), 0
deletions(-)<br class="">
<br class="">
</tt></div>
<br class="">
<hr class="">
<p class="" align="center">To unsubscribe from
the CCTBX-COMMIT list, click the following
link:<br class="">
<a
href="https://www.jiscmail.ac.uk/cgi-bin/WA-JISC.exe?SUBED1=CCTBX-COMMIT&A=1"
target="_blank" class=""
moz-do-not-send="true">https://www.jiscmail.ac.uk/cgi-bin/WA-JISC.exe?SUBED1=CCTBX-COMMIT&A=1</a>
</p>
</div>
</blockquote>
</div>
<br class="">
</div>
<div class=""> <br class="webkit-block-placeholder">
</div>
<p class="" align="justify">-- </p>
<p class="" align="justify">This e-mail and any
attachments may contain confidential, copyright and
or privileged material, and are for the use of the
intended addressee only. If you are not the intended
addressee or an authorised recipient of the
addressee please notify us of receipt by returning
the e-mail and do not use, copy, retain, distribute
or disclose the information in or attached to the
e-mail.<br class="">
Any opinions expressed within this e-mail are those
of the individual and not necessarily of Diamond
Light Source Ltd.
<br class="">
Diamond Light Source Ltd. cannot guarantee that this
e-mail or any attachments are free from viruses and
we cannot accept liability for any damage which you
may sustain as a result of software viruses which
may be transmitted in or with the message.<br
class="">
Diamond Light Source Limited (company no. 4375679).
Registered in England and Wales with its registered
office at Diamond House, Harwell Science and
Innovation Campus, Didcot, Oxfordshire, OX11 0DE,
United Kingdom<br class="">
</p>
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
cctbxbb mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cctbxbb@phenix-online.org" moz-do-not-send="true">cctbxbb@phenix-online.org</a>
<a class="moz-txt-link-freetext" href="http://phenix-online.org/mailman/listinfo/cctbxbb" moz-do-not-send="true">http://phenix-online.org/mailman/listinfo/cctbxbb</a>
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Robert Oeffner, Ph.D.
Research Associate, The Read Group
Department of Haematology,
Cambridge Institute for Medical Research
University of Cambridge
Cambridge Biomedical Campus
The Keith Peters Building
Hills Road
Cambridge CB2 0XY
<a class="moz-txt-link-abbreviated" href="http://www.cimr.cam.ac.uk/investigators/read/index.html" moz-do-not-send="true">www.cimr.cam.ac.uk/investigators/read/index.html</a>
tel: +44(0)1223 763234</pre>
<div id="DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2" class=""><br
class="">
<table style="border-top: 1px solid #D3D4DE;" class="">
<tbody class="">
<tr class="">
<td style="width: 55px; padding-top: 13px;"
class=""><a
href="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient"
target="_blank" class=""
moz-do-not-send="true"><img
src="https://ipmcdn.avast.com/images/icons/icon-envelope-tick-green-avg-v1.png"
alt="" style="width: 46px; height: 29px;"
class="" moz-do-not-send="true" width="46"
height="29"></a></td>
<td style="width: 470px; padding-top: 12px;
color: #41424e; font-size: 13px; font-family:
Arial, Helvetica, sans-serif; line-height:
18px;" class="">
Virus-free. <a
href="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient"
target="_blank" style="color: #4453ea;"
class="" moz-do-not-send="true">
www.avg.com</a> </td>
</tr>
</tbody>
</table>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
<p align="justify"> </p>
<p align="justify">-- </p>
<p align="justify">This e-mail and any attachments may contain
confidential, copyright and or privileged material, and are for
the use of the intended addressee only. If you are not the
intended addressee or an authorised recipient of the addressee
please notify us of receipt by returning the e-mail and do not
use, copy, retain, distribute or disclose the information in or
attached to the e-mail.<br>
Any opinions expressed within this e-mail are those of the
individual and not necessarily of Diamond Light Source Ltd. <br>
Diamond Light Source Ltd. cannot guarantee that this e-mail or
any attachments are free from viruses and we cannot accept
liability for any damage which you may sustain as a result of
software viruses which may be transmitted in or with the
message.<br>
Diamond Light Source Limited (company no. 4375679). Registered
in England and Wales with its registered office at Diamond
House, Harwell Science and Innovation Campus, Didcot,
Oxfordshire, OX11 0DE, United Kingdom<br>
</p>
</blockquote>
<pre class="moz-signature" cols="72">--
Robert Oeffner, Ph.D.
Research Associate, The Read Group
Department of Haematology,
Cambridge Institute for Medical Research
University of Cambridge
Cambridge Biomedical Campus
The Keith Peters Building
Hills Road
Cambridge CB2 0XY
<a class="moz-txt-link-abbreviated" href="http://www.cimr.cam.ac.uk/investigators/read/index.html">www.cimr.cam.ac.uk/investigators/read/index.html</a>
tel: +44(0)1223 763234</pre>
</body>
</html>