<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
Hi Folks
<div class=""><br class="">
</div>
<div class="">Would anyone be offended if we had a pre-commit hook which ran the clutter / unused imports tests to stop the history fulling up with clean clutter commits?</div>
<div class=""><br class="">
</div>
<div class="">If clutter is important, probably should not let it in in the first place?</div>
<div class=""><br class="">
</div>
<div class="">I’m not suggesting anything extreme like black, like we use for dxtbx and dials, just running the tools that developers are supposed to run before commits</div>
<div class=""><br class="">
</div>
<div class="">Cheers Graeme<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">Begin forwarded message:</div>
<br class="Apple-interchange-newline">
<div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class="">
<span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">From:
</b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">CCTBX commit <<a href="mailto:diamondlightsource.jenkins@GMAIL.COM" class="">diamondlightsource.jenkins@GMAIL.COM</a>><br class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class="">
<span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Subject:
</b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">[git/cctbx_project] master: de-clutter (e9be98075a)</b><br class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class="">
<span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Date:
</b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">7 October 2020 at 12:56:50 BST<br class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class="">
<span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">To:
</b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:CCTBX-COMMIT@JISCMAIL.AC.UK" class="">CCTBX-COMMIT@JISCMAIL.AC.UK</a><br class="">
</span></div>
<div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class="">
<span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Reply-To:
</b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><a href="mailto:cctbxbb@PHENIX-ONLINE.ORG" class="">cctbxbb@PHENIX-ONLINE.ORG</a><br class="">
</span></div>
<br class="">
<div class="">
<div class=""><tt class="">Repository : <a href="https://github.com/cctbx/cctbx_project/" class="">
https://github.com/cctbx/cctbx_project/</a><br class="">
On branch : master<br class="">
Link : <a href="https://github.com/cctbx/cctbx_project/commit/e9be98075a31f4584f1eca41f9eba5e408d0cb8f" class="">
https://github.com/cctbx/cctbx_project/commit/e9be98075a31f4584f1eca41f9eba5e408d0cb8f</a><br class="">
<br class="">
<hr class="">
<br class="">
<br class="">
commit e9be98075a31f4584f1eca41f9eba5e408d0cb8f<br class="">
Author: Robert Oeffner <<a href="mailto:rdo20@cam.ac.uk" class="">rdo20@cam.ac.uk</a>><br class="">
Date: Wed Oct 7 12:56:50 2020 +0100<br class="">
<br class="">
de-clutter<br class="">
<br class="">
<br class="">
<hr class="">
<br class="">
<br class="">
e9be98075a31f4584f1eca41f9eba5e408d0cb8f<br class="">
cctbx/miller/__init__.py | 0<br class="">
1 file changed, 0 insertions(+), 0 deletions(-)<br class="">
<br class="">
</tt></div>
<br class="">
<hr class="">
<p align="center" class="">To unsubscribe from the CCTBX-COMMIT list, click the following link:<br class="">
<a href="https://www.jiscmail.ac.uk/cgi-bin/WA-JISC.exe?SUBED1=CCTBX-COMMIT&A=1" target="_blank" class="">https://www.jiscmail.ac.uk/cgi-bin/WA-JISC.exe?SUBED1=CCTBX-COMMIT&A=1</a>
</p>
</div>
</blockquote>
</div>
<br class="">
</div>
<p align="justify"> </p>
<p align="justify">-- </p>
<p align="justify">This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.<br />Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. <br />Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.<br />Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom<br /> </p></body>
</html>