[cctbxbb] Fwd: buildbot failure in Phenix on cctbx-ci-ci

Tue Jun 5 11:03:06 PDT 2018

Art

It is not fixed. If you run

libtbx.find_clutter  iota_single_image.py

it will tell you what you have not fixed. I suggest always running this
before committing.

Cheers

Nigel

---
Nigel W. Moriarty
Building 33R0349, Molecular Biophysics and Integrated Bioimaging
Lawrence Berkeley National Laboratory
Berkeley, CA 94720-8235
Phone : 510-486-5709     Email : NWMoriarty at LBL.gov
Fax   : 510-486-5909       Web  : CCI.LBL.gov

On Mon, Jun 4, 2018 at 4:51 PM, Artem Lyubimov <lyubimov at stanford.edu>
wrote:

> I profusely apologize for the drama that I've caused. I have now fixed the
> offending file and vow to be more careful in the future.
>
> Art
>
> On Mon, Jun 4, 2018 at 4:47 PM, Nigel Moriarty <nwmoriarty at lbl.gov> wrote:
>
>> Aaron is correct. It's the first person who is responsible so you can
>> blame Art for the clutter and then completely ignoring the email telling
>> him to fix it.
>>
>> Cheers
>>
>> Nigel
>>
>> ---
>> Nigel W. Moriarty
>> Building 33R0349, Molecular Biophysics and Integrated Bioimaging
>> Lawrence Berkeley National Laboratory
>> Berkeley, CA 94720-8235
>> Phone : 510-486-5709     Email : NWMoriarty at LBL.gov
>> Fax   : 510-486-5909       Web  : CCI.LBL.gov
>>
>> On Mon, Jun 4, 2018 at 4:43 PM, Aaron Brewster <asbrewster at lbl.gov>
>> wrote:
>>
>>> Hi Graeme, I don't find these more annoying than the Jenkins build
>>> failure emails.  In fact, these buildbot emails are targeted to whoever
>>> committed the clutter, or at least the first one is anyway.  Be happy,
>>> Nigel and I get *all* the buildbot continuous-integration emails, you only
>>> get a couple!
>>>
>>> A smarter build-bot post-commit hook would be nice, one that only alerts
>>> once per bad commit.  The relevant class is BBCCTBXCIBuilder in master.cfg
>>> in the cci buildbot svn repo.  It would need to get the last commit and
>>> only run find_clutter on those files.  Perhaps a --last-commit-only flag
>>> could be added to libtbx.find_clutter, which could then be used by BBCCTBXCIBuilder?
>>> Of course, then untended clutter could start to build up...
>>>
>>> -Aaron
>>>
>>>
>>>
>>> On Mon, Jun 4, 2018 at 4:25 AM, Graeme.Winter at Diamond.ac.uk <
>>> Graeme.Winter at diamond.ac.uk> wrote:
>>>
>>>> Hi Folks,
>>>>
>>>> Am I alone in finding this kind of message ** very ** annoying
>>>>
>>>> I did not touch this file
>>>> I have no business touching this file
>>>> If I do fix this then it may cause conflicts for others, which will no
>>>> doubt annoy them far more than the odd extra space in the code
>>>>
>>>> However I am also now to blame for breaking the Phenix build, in the
>>>> run up to a release
>>>>
>>>> This is no a happy place
>>>>
>>>> Suggestions?
>>>>
>>>> Thanks & cheerio Graeme
>>>>
>>>> Begin forwarded message:
>>>>
>>>> From: phenix at phenix-online.org<mailto:phenix at phenix-online.org>
>>>> Subject: buildbot failure in Phenix on cctbx-ci-ci
>>>> Date: 4 June 2018 at 12:11:19 BST
>>>> To: graeme.winter at gmail.com<mailto:graeme.winter at gmail.com>
>>>> Cc: ASBrewster at LBL.Gov<mailto:ASBrewster at LBL.Gov>, NWMoriarty at LBL.Gov
>>>> <mailto:NWMoriarty at LBL.Gov>
>>>>
>>>> Build status: FAILURE
>>>> Buildslave for this Build:      ci
>>>> Complete logs for all build steps:      http://cci-vm-6.lbl.gov:8010/b
>>>> uilders/cctbx-ci-ci/builds/5580
>>>> Build Reason:   The SingleBranchScheduler scheduler named
>>>> 'cctbx-ci.poll' triggered this build
>>>> Build Source Stamp:     clipper: [branch master] HEAD
>>>>
>>>> cbflib: [branch master] HEAD
>>>>
>>>> cctbx_project: [branch master] 4de5e7f82b0302632282f78c6dda8b999cf6abf6
>>>>
>>>> annlib_adaptbx: [branch master] HEAD
>>>>
>>>> tntbx: [branch master] HEAD
>>>>
>>>> ccp4io_adaptbx: [branch master] HEAD
>>>>
>>>> boost: [branch master] HEAD
>>>>
>>>> gui_resources: [branch master] HEAD
>>>>
>>>>
>>>> Blamelist:      graeme-winter
>>>> If you got an email and you didn't touch this file, it may because
>>>> someone commited this file before you with an error and hasn't fixed it
>>>> yet. You might have noticed the error if you ran libtbx.find_clutter on the
>>>> entire tree.
>>>>
>>>> Detailed log of last build step: http://cci-vm-6.lbl.gov:8010/b
>>>> uilders/cctbx-ci-ci/builds/5580/steps/test ALL clutter/logs/stdio<
>>>> http://cci-vm-6.lbl.gov:8010/builders/cctbx-ci-ci/builds/5580/steps/tes
>>>> t%20ALL%20clutter/logs/stdio>
>>>> Last 80 lines of "test ALL clutter.stdio"
>>>>
>>>> iota/command_line/iota_single_image.py: tabs or trailing whitespace=2,
>>>> #10, #11
>>>>
>>>> *** To clean up please use: libtbx.clean_clutter ***
>>>>
>>>>
>>>> -The Buildbot
>>>>
>>>>
>>>> --
>>>> This e-mail and any attachments may contain confidential, copyright and
>>>> or privileged material, and are for the use of the intended addressee only.
>>>> If you are not the intended addressee or an authorised recipient of the
>>>> addressee please notify us of receipt by returning the e-mail and do not
>>>> use, copy, retain, distribute or disclose the information in or attached to
>>>> the e-mail.
>>>> Any opinions expressed within this e-mail are those of the individual
>>>> and not necessarily of Diamond Light Source Ltd.
>>>> Diamond Light Source Ltd. cannot guarantee that this e-mail or any
>>>> attachments are free from viruses and we cannot accept liability for any
>>>> damage which you may sustain as a result of software viruses which may be
>>>> transmitted in or with the message.
>>>> Diamond Light Source Limited (company no. 4375679). Registered in
>>>> England and Wales with its registered office at Diamond House, Harwell
>>>> Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
>>>>
>>>>
>>>> _______________________________________________
>>>> cctbxbb mailing list
>>>> cctbxbb at phenix-online.org
>>>> http://phenix-online.org/mailman/listinfo/cctbxbb
>>>>
>>>
>>>
>>> _______________________________________________
>>> cctbxbb mailing list
>>> cctbxbb at phenix-online.org
>>> http://phenix-online.org/mailman/listinfo/cctbxbb
>>>
>>>
>>
>
>
> --
> Artem Y. Lyubimov, PhD
> Staff Scientist
> SSRL SMB Crystallography
> 2525 Sand Hill Road
> <https://maps.google.com/?q=2525+Sand+Hill+Road&entry=gmail&source=g>
> mail stop 99
> Menlo Park, CA 94025-7015
> (650) 926-5595
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://phenix-online.org/pipermail/cctbxbb/attachments/20180605/b2370c2a/attachment.htm>